From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125223 invoked by alias); 20 May 2015 23:17:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125213 invoked by uid 89); 20 May 2015 23:17:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wi0-f177.google.com Received: from mail-wi0-f177.google.com (HELO mail-wi0-f177.google.com) (209.85.212.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 20 May 2015 23:17:52 +0000 Received: by wibt6 with SMTP id t6so76436169wib.0 for ; Wed, 20 May 2015 16:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vLz1jALdDdjtLzVDy1Sfj9bRyXf+rryzh9oQMzc8fS0=; b=ghGKFDLLrq2OEb83hg36Mm8By796HKS/6SY0Bc1wFtJs9daz7AcoZabyxLdiGtcoct crCbMLrCWGHCSTYNEpSEHQhpnQ9rKYb9vGyMr1/an2BBYgNwJFEgIpUawVvTh+k2llmU TQnzZWnk60LRtl5vsM+uN0WWiYZvSFsYuVljJ8gWn8IqXqAfbC3TRMicue/PVXf5GdVK 48AWWsALjCgFxhAyRDCw0YMNQ12u7vi4R+zfmYFP9syqUCxbgWOmjRPaZlZwS4zOaMVC x0OQ8S5XgmfOmD18ZX1zVhE7sNIQELiACDOrF+I+nrR9+9wjAYY8BJft1AUJV9IHcCkH J9lA== X-Gm-Message-State: ALoCoQk3M+zuWUkPeEoFC6UnAz3BcHykXRjAhg4NVv7S6HSMH78oHGDQnrbXDOSsopyfTRcnEDBz X-Received: by 10.194.79.225 with SMTP id m1mr4083319wjx.8.1432163869290; Wed, 20 May 2015 16:17:49 -0700 (PDT) Received: from localhost ([46.189.28.220]) by mx.google.com with ESMTPSA id u6sm29126038wjy.13.2015.05.20.16.17.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 May 2015 16:17:48 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/4] layout command changes Date: Wed, 20 May 2015 23:17:00 -0000 Message-Id: X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00520.txt.bz2 This patch set replaces an earlier patch I posted here: https://sourceware.org/ml/gdb-patches/2015-04/msg00185.html In the previous patch I had to jump through some hoops in order to support completion of the layout names like $FREGS. This was pretty annoying as I had not realised these layouts existed until I started writting the completer code... ...but it turns out that those layout names don't work anyway, and have not done so for some time. I didn't figure out exactly when they broke, but I believe they were broken in 6.8. Still, it doesn't matter, as we have the 'tui regs' command, which does work, and does allow the register set displayed in tui to be changed. This is for the best anyway (I think), personally, I felt that managing both the layout, and the choice of register set all from the layout command was too much overloading. The first patch in this series removes the $FREGS style register set names from the layout command, and cleans up all of the code relating to them. The second patch is a much simpler version of command completion support for layout names. The third and forth patches fix small tui related issues that I spotted during testing. Thanks, Andrew -- Andrew Burgess (4): gdb: Remove register class specific layout names. gdb: Add completer for layout command. gdb: Don't call tui_enable too early. gdb: Add cleanup to avoid memory leak on error. gdb/ChangeLog | 49 ++++++ gdb/testsuite/ChangeLog | 5 + gdb/testsuite/gdb.base/completion.exp | 19 +++ gdb/tui/tui-data.c | 10 +- gdb/tui/tui-data.h | 23 --- gdb/tui/tui-layout.c | 296 +++++++++++++++------------------- gdb/tui/tui-layout.h | 3 +- gdb/tui/tui.c | 8 +- 8 files changed, 210 insertions(+), 203 deletions(-) -- 2.4.0