From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82251 invoked by alias); 26 Sep 2017 12:11:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81653 invoked by uid 89); 26 Sep 2017 12:11:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=month X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 12:11:28 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82B26C0860CB; Tue, 26 Sep 2017 12:11:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 82B26C0860CB Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEC2166829; Tue, 26 Sep 2017 12:11:25 +0000 (UTC) Subject: Re: [RFA 01/67] Add add_cmd function overloads To: Tom Tromey , "Metzger, Markus T" References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-2-tom@tromey.com> <87vakagigf.fsf@tromey.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Tue, 26 Sep 2017 12:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87vakagigf.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00791.txt.bz2 On 09/23/2017 05:14 AM, Tom Tromey wrote: >>>>>> "Markus" == Metzger, Markus T writes: > >>> static void >>> +do_const_cfunc (struct cmd_list_element *c, char *args, int from_tty) >>> +{ >>> + c->function.const_cfunc (args, from_tty); /* Ok. */ >>> +} > > Markus> Ok.? > > This is copy-and-paste from the other function like this. > I think this is some way to suppress ARI warnings. I thought so too, though grepping for "Ok" in the ARI finds no hits. We have some markers in the tree for ARI, but they start with "ARI: ". I'd zap the "Ok." comments see what happens. You can run the ARI locally and compare with/without "Ok." comments, with something like: gdb/contrib/ari/gdb_ari.sh -Wall gdb/cli/cli-decode.c > I don't know if ARI is still used...? It was still sending notifications to the list as recently as this month. Thanks, Pedro Alves