Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Guinevere Larsen <guinevere@redhat.com>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Cc: Christina Joos <christina.joos@intel.com>
Subject: Re: [PATCH v2] gdb/record: avoid rax usage in i386-avx-record.exp
Date: Thu, 13 Aug 2026 12:07:33 -0300	[thread overview]
Message-ID: <cf945a02-9004-40dc-b060-bc10828ec161@redhat.com> (raw)
In-Reply-To: <91d78916-4871-4264-8d27-4d221ee424b5@simark.ca>

On 8/13/26 11:51 AM, Simon Marchi wrote:
> On 8/13/26 9:10 AM, Guinevere Larsen wrote:
>> My recent commit, 1c04308f0958cbac83bad22703758139ea6969b6:
>>
>>      Author: Guinevere Larsen <guinevere@redhat.com>
>>      Date:   Tue Jun 16 16:03:43 2026 -0300
>>      gdb/record: add support for BMI2 instructions
>>
>> Introduced a few tests that rely on the rax register being set before
>> entering the function. This isn't reliable, as programs compiled with
>> gcc-14 and earlier will have the register. To avoid compiler versions
> This sentence ends abruptly.
>
> It's not clear to me what the problem is, could you explain it in simple
> words :)?
>
> Simon
>
oops, sorry, need to do more proofreading I guess. The sentence should 
be "will have the registered clobbered, saving 0 on it"

I haven't looked at the disassembly to know why, but something about how 
GCC 14 encodes the function calls makes EAX be 0 every time, and the 
test expects eax to be something else. Moving to a different register 
sidesteps this

-- 
Cheers,
Guinevere Larsen
it/its
she/her (deprecated)


      reply	other threads:[~2026-08-13 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 13:10 Guinevere Larsen
2026-08-13 14:51 ` Simon Marchi
2026-08-13 15:07   ` Guinevere Larsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf945a02-9004-40dc-b060-bc10828ec161@redhat.com \
    --to=guinevere@redhat.com \
    --cc=christina.joos@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox