From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133049-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 74741 invoked by alias); 24 Aug 2016 15:38:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 74682 invoked by uid 89); 24 Aug 2016 15:38:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=online
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Aug 2016 15:38:30 +0000
Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90])	by  (Symantec Mail Security) with SMTP id 4C.CB.02568.0A0CDB75; Wed, 24 Aug 2016 17:43:28 +0200 (CEST)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.92) with Microsoft SMTP Server id 14.3.301.0; Wed, 24 Aug 2016 11:36:19 -0400
Subject: Re: [PATCH] Allow resetting an empty inferior-tty
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
References: <20160824144548.19204-1-simon.marchi@ericsson.com> <02a660a4-13e9-d741-577a-0aaef7c196ae@redhat.com>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <cf2d227d-ec11-2731-339a-3e420d481a3f@ericsson.com>
Date: Wed, 24 Aug 2016 15:38:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <02a660a4-13e9-d741-577a-0aaef7c196ae@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-08/txt/msg00247.txt.bz2

On 16-08-24 11:33 AM, Pedro Alves wrote:
>> +  if (terminal_name != NULL && strlen (terminal_name) > 0)
> 
> Use th idiomatic empty-string check: *terminal_name != '\0'

Done.

>>    /* Add the filename of the terminal connected to inferior I/O.  */
>> -  add_setshow_filename_cmd ("inferior-tty", class_run,
>> -			    &inferior_io_terminal_scratch, _("\
>> +  add_setshow_optional_filename_cmd ("inferior-tty", class_run,
>> +				     &inferior_io_terminal_scratch, _("\
>>  Set terminal for future runs of program being debugged."), _("\
>>  Show terminal for future runs of program being debugged."), _("\
>>  Usage: set inferior-tty /dev/pts/1"),
> 
> Should we update the online help too?

The online help is generated from the doc, which I updated, so it should
be ok, no?  Unless you are talking about something else?