From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94998 invoked by alias); 27 Oct 2016 16:10:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94943 invoked by uid 89); 27 Oct 2016 16:10:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 16:10:30 +0000 Received: by simark.ca (Postfix, from userid 33) id A21361E96D; Thu, 27 Oct 2016 12:10:28 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH 7/7] Add documentation for new instruction record Python bindings. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Oct 2016 16:10:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, palves@redhat.com, markus.t.metzger@intel.com In-Reply-To: <1477549711-2603-8-git-send-email-tim.wiederhake@intel.com> References: <1477549711-2603-1-git-send-email-tim.wiederhake@intel.com> <1477549711-2603-8-git-send-email-tim.wiederhake@intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00771.txt.bz2 On 2016-10-27 02:28, Tim Wiederhake wrote: > +@defun gdb.start_recording ([method]) > +Starts a recording using the given @var{method}. If no @var{method} > is > +given, the default method will be used. Returns a @code{gdb.Record} > +object on success. Throws an exception on failure. The following > +methods are currently supported: Would it be better to separate the method and format? Like: gdb.start_recording([method], [format]); Omitting the format would let the method choose the best format (like pt vs bts for btrace). Also, for a programmatic API such as this one, I don't really see the advantage of allowing shorthands like "pt" instead of "btrace pt". It makes the code and API more complex with not much gain. Thanks, Simon