From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MsFzC37SLWkafQwAWB0awg (envelope-from ) for ; Mon, 01 Dec 2025 12:38:06 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=AiiQP8jP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C84331E08D; Mon, 01 Dec 2025 12:38:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 332E01E08D for ; Mon, 01 Dec 2025 12:38:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD0A948FD876 for ; Mon, 1 Dec 2025 17:38:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD0A948FD876 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=AiiQP8jP Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C39FF48FD84A for ; Mon, 1 Dec 2025 17:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C39FF48FD84A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C39FF48FD84A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764610660; cv=none; b=PlM7/STJqsgiS+gjK4wMB0T52A1gc3JfgrEzgY7FN1My/P9Oc02TPYkYOVoUaVQdk1zIlTIEmYF/kJB5FtWzlnj9syI4VedQ9KCnZBw7LVN1wHZv9GJhN5gsbpm+aO6pFnIZp0N5P71PwRAwyuQRS05QuQd2X7LixKaylw/qunE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764610660; c=relaxed/simple; bh=c0zC9XyPTp80Ld2p9E2kW1ZH1xZdZbKRZD6+aOcFm04=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XMcfHzsuHdfdLJQWxG1HF9FvHHZnyxfCNLTSpq6K6d/eAVOvca65yONwIrk+0hyo1gSCUCHfKKUbC25eJgEu467s7snSZv9Z2jCBzGvPCJU2k0qfvNTFulr2ozEHyrerzVL71RiaKWnvgsOosjkZiijYWzX+qzSM2S/XvmQJev0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C39FF48FD84A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 5B1HbZUT193067 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Dec 2025 12:37:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 5B1HbZUT193067 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1764610660; bh=XdFO01cAOOUUW0zZJxh9fRfUllO/NVxo1QX6QFXgkUU=; h=Date:Subject:To:From:In-Reply-To:From; b=AiiQP8jPM1NVwCNS52qLYfbgQgn+Pe2M+6+reJsOARih88djOZ5BQRO/Snn8oC8kK TiXVEDNNAReiRyHF/hJ6JthdIPhiT8TgKqyiMlVVJ+mK1nmO3WU1aoDTDmGHlBavx0 +mOpdmilOLEUahQG5lm72lvrq6j95ohUUy6tk3T0ghUYqpQm9B2lNAkJSOisTSf0I1 x8m3fDFjhryqr4U4jZxHqlmffVXO1KJbvGYB2zLn46VqvNgU5WV4fG1iYeDIGDXH0r cEExZzDJq3SOBnqI4SKbubId4f3gj+IteTa0GMdYAcFhjb+ijO8wFOEIW0xExcWoEw 5hInmcj2x/XeQ== Received: by simark.ca (Postfix) id DC4741E08D; Mon, 01 Dec 2025 12:37:34 -0500 (EST) Message-ID: Date: Mon, 1 Dec 2025 12:37:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix a few typos To: Tom de Vries , gdb-patches@sourceware.org References: <20251124215409.3761464-1-simon.marchi@polymtl.ca> <195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de> <7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca> <7ead3569-5727-4f12-a9eb-40acf3193c3a@suse.de> <97d882dc-025c-4bce-90e4-8fdeb805390d@polymtl.ca> <2924a089-07a2-4742-ba9f-a1ae409ed0dc@suse.de> Content-Language: en-US From: Simon Marchi In-Reply-To: <2924a089-07a2-4742-ba9f-a1ae409ed0dc@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 1 Dec 2025 17:37:35 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-12-01 12:27, Tom de Vries wrote: > On 12/1/25 6:16 PM, Simon Marchi wrote: >> On 2025-12-01 12:12, Tom de Vries wrote: >>> Interesting. >>> >>> I wonder if that will still work with my proposal for moving the >>> commit-log check from the commit-msg to the post-commit stage ( >>> https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html >>> ), in which case the commit message is produced by a wrapper script, >>> and not by git as is the case for the commit-msg stage. >> >> Depends, what do you mean by "will still work"? > > Well, in the commit-msg stage, git will provide a file to the pre-commit hook containing the commit message. > > In the post-commit stage, git doesn't provide such a file, and the pre-commit calls a wrapper script which call git to generate the commit message. So my question is whether the alias (shell alias or git alias?) will be active in this scenario or not. It's still not clear to me which part you wonder will still work. The part where codespell checks the patch diff that happened to be in my editor? If so, it's not a problem, it wasn't intended to work this way anyway. They are shell aliases: $ alias gc gc! gc='git commit --verbose' 'gc!'='git commit --verbose --amend' from oh-my-zsh: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/git You can define the same aliases if you want to try it yourself. Simon