Re: [PATCH v2] [gdb] Remove unnecessary defs.h/common-defs.h includes

[Tom de Vries <tdevries@suse.de>]

On 4/21/26 9:53 PM, Simon Marchi wrote:
> On 4/21/26 3:40 PM, Tom de Vries wrote:
>> I asked an AI to review a patch that added a new file, and it mentioned I
>> should add an include of defs.h as first include.
>>
>> That used to be true, but since commit 18d2988e5da ("gdb, gdbserver,
>> gdbsupport: remove includes of early headers") that's not the case anymore.
> 
> Btw, this is the kind of details that we could put in an AGENTS.md file
> (or similar), if it doesn't offend too many people.  AIs are much more
> efficient if they know the conventions of the project ahead of time.

I've opened a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33951 
) about adding an AGENTS.md file, with a similar idea.

Kevin added a comment about how that may not necessarily work well.

Thanks,
- Tom

> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> Simon
>