From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 5/8] Remove cleanups from find_frame_funname
Date: Mon, 11 Sep 2017 20:25:00 -0000 [thread overview]
Message-ID: <ceb6dfe6da7379bd18a05671ea473a3b@polymtl.ca> (raw)
In-Reply-To: <20170910215037.24329-6-tom@tromey.com>
> diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
> index b2af743..f504a88 100644
> --- a/gdb/guile/scm-frame.c
> +++ b/gdb/guile/scm-frame.c
> @@ -418,7 +418,7 @@ static SCM
> gdbscm_frame_name (SCM self)
> {
> frame_smob *f_smob;
> - char *name = NULL;
> + gdb::unique_xmalloc_ptr<char> name;
> enum language lang = language_minimal;
> struct frame_info *frame = NULL;
> SCM result;
> @@ -429,11 +429,10 @@ gdbscm_frame_name (SCM self)
> {
> frame = frscm_frame_smob_to_frame (f_smob);
> if (frame != NULL)
> - find_frame_funname (frame, &name, &lang, NULL);
> + name = find_frame_funname (frame, &lang, NULL);
> }
> CATCH (except, RETURN_MASK_ALL)
> {
> - xfree (name);
> GDBSCM_HANDLE_GDB_EXCEPTION (except);
> }
> END_CATCH
> @@ -446,8 +445,7 @@ gdbscm_frame_name (SCM self)
>
> if (name != NULL)
> {
> - result = gdbscm_scm_from_c_string (name);
> - xfree (name);
> + result = gdbscm_scm_from_c_string (name.get ());
> }
Nit: curly braces not needed.
Simon
next prev parent reply other threads:[~2017-09-11 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 21:50 [RFA 0/8] various cleanup removals Tom Tromey
2017-09-10 21:50 ` [RFA 7/8] Use std::string in d-namespace.c Tom Tromey
2017-09-10 21:50 ` [RFA 2/8] Replace interp_set_temp with scoped_restore_interp Tom Tromey
2017-09-10 21:50 ` [RFA 5/8] Remove cleanups from find_frame_funname Tom Tromey
2017-09-11 20:25 ` Simon Marchi [this message]
2017-09-10 21:50 ` [RFA 4/8] Remove cleanups from findcmd.c Tom Tromey
2017-09-10 21:50 ` [RFA 3/8] Replace clear_hook_in_cleanup with scoped_restore_hook_in Tom Tromey
2017-09-10 21:50 ` [RFA 8/8] Remove make_show_memory_breakpoints_cleanup Tom Tromey
2017-09-11 20:34 ` Simon Marchi
2017-09-10 21:50 ` [RFA 6/8] Use std::string in ctf_start Tom Tromey
2017-09-10 21:50 ` [RFA 1/8] Change setup_breakpoint_reporting to return a scoped_restore Tom Tromey
2017-09-11 20:35 ` [RFA 0/8] various cleanup removals Simon Marchi
2017-09-11 22:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb6dfe6da7379bd18a05671ea473a3b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox