From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54442 invoked by alias); 8 Jul 2018 16:49:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54053 invoked by uid 89); 8 Jul 2018 16:49:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:49:13 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2CF0E1E059; Sun, 8 Jul 2018 12:49:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531068552; bh=KhvYrnbWfzAXQvkbTMNtX1dv+gxAiVKx5q9hquWF4DM=; h=Subject:To:References:From:Date:In-Reply-To:From; b=X0T7KPzUDPaPuNOr3yw8GdroMSUQ4GghSrDe6XFsEtpTJsgbbHH5WD5k1GAQzYvy3 jQONttBo74mraZiOtwsWHUDqV8baz46WklYuD2cxURGDqI3pxki7GSqaJIBVlZ/RJu LR9/liS9shVgq5Np5B6uUE7Tj74/14J0yljZjDAM= Subject: Re: [RFA 12/42] Move within_function to stabsread To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-13-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 08 Jul 2018 16:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-13-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00195.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > The global within_function is only used by a few symbol readers. This > patch moves the global out of buildsym and into stabsread, which > seemed like a better fit. It also arranges for the existing readers > to clear the global at the appropriate time. LGTM.