Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH testsuite] Clean-up gdb.ada test names
Date: Mon, 11 May 2020 20:49:11 +0200	[thread overview]
Message-ID: <ce7d7833-ca3d-be17-1f91-56565caf65db@suse.de> (raw)
In-Reply-To: <20200508190028.1935494-1-keiths@redhat.com>

On 08-05-2020 21:00, Keith Seitz via Gdb-patches wrote:
> -gdb_test "print s'last"  " = 3"
> +    gdb_test "print s'last"  " = 3Z

Hi Keith,

Missing double quote at eol (instead, we have "Z").

This causes:
...
ERROR: tcl error sourcing
/data/gdb_versions/devel/src/gdb/testsuite/gdb.ada/attr_ref_and_charlit.exp.
ERROR: extra characters after close-quote
    while executing
"gdb_test "print s'last"  " = 3Z
    gdb_test "p"
    ("uplevel" body line 3)
    invoked from within
"uplevel 1 $body"
    invoked from within
"with_test_prefix "run" {
    gdb_test "print s'first" " = 2"
    gdb_test "print s'last"  " = 3Z
    gdb_test "print s(s'first) = 'a'" " = true"
    g..."
    (file
"/data/gdb_versions/devel/src/gdb/testsuite/gdb.ada/attr_ref_and_charlit.exp"
line 32)
    invoked from within
"source
/data/gdb_versions/devel/src/gdb/testsuite/gdb.ada/attr_ref_and_charlit.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source
/data/gdb_versions/devel/src/gdb/testsuite/gdb.ada/attr_ref_and_charlit.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
...

Thanks,
- Tom


  parent reply	other threads:[~2020-05-11 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 19:00 Keith Seitz
2020-05-08 20:40 ` Tom Tromey
2020-05-11 18:05   ` Keith Seitz
2020-05-11 18:49 ` Tom de Vries [this message]
2020-05-11 19:30   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce7d7833-ca3d-be17-1f91-56565caf65db@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox