From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id C31863890417 for ; Thu, 18 Jun 2020 17:32:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C31863890417 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-2oqQshsBNZqT0WlUQ0TqFA-1; Thu, 18 Jun 2020 13:32:45 -0400 X-MC-Unique: 2oqQshsBNZqT0WlUQ0TqFA-1 Received: by mail-wr1-f71.google.com with SMTP id e7so3086896wrp.14 for ; Thu, 18 Jun 2020 10:32:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmtJ3+VO82JJucaoys9+pC1xjnegL/fGMAJaR14A8Iw=; b=r7TgQ1FX/rLHWsDVxtnFBZLNyWOPkeWOEZkYiF5hwsmyJIIHz5jQztP86uM1NMi5FH P0SnMQnfMc+yeESGDc/9+wNKz6J76E64PmyJyQYPlS52/eOkXG+Vo8snEA+zkSqEid5i 2L5qeDpIQeOp53pgYGUrCkoaV0Nh8D996MK32Ar4QpI7FWFwK/b9XS7NDEwBX1kj6giK TCP55CFUwVDE8R5zTN3LyxctQLoGAMl1Ryqc8X2Au3NX9vyWKWBLWahyAV2OTkUwvVTJ MvcEOyftVgf0mhZOwKodZz7ptyKVoPDEskkNBc75AMv4veRDW11u4oLOVDgv/KEXeyCf 0NCw== X-Gm-Message-State: AOAM531sX2v24OUezyU7/IvT4EeLfveJth/Mhb+eIUdT3D3iO5bBZPLz FqvOQLUEHmlhKERzUZ6Zsh1gt0khrMFXCxisO1Q2xe/71kXpO/W6QF3zt0GZI2dbAMQnKYWRak0 qaNcPFPC09WtK8ppNlr+RDA== X-Received: by 2002:a1c:1d93:: with SMTP id d141mr2584422wmd.14.1592501564499; Thu, 18 Jun 2020 10:32:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9gDB+If9Vsq/vGRsB8DiPbovn3lXprXwCj798b+pyhbElsqgW6JrNrCss3Tet83PMf2BL8w== X-Received: by 2002:a1c:1d93:: with SMTP id d141mr2584405wmd.14.1592501564244; Thu, 18 Jun 2020 10:32:44 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id p16sm4799176wru.27.2020.06.18.10.32.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 10:32:43 -0700 (PDT) Subject: Re: [PATCH 2/3] Consistently use BFD's time To: Eli Zaretskii , Tom Tromey References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> <87k1044g1x.fsf@tromey.com> <83r1ucza8u.fsf@gnu.org> <87wo442wjq.fsf@tromey.com> <83o8pgz3lv.fsf@gnu.org> Cc: gdb-patches@sourceware.org, tromey@adacore.com From: Pedro Alves Message-ID: Date: Thu, 18 Jun 2020 18:32:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83o8pgz3lv.fsf@gnu.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 17:32:49 -0000 On 6/18/20 6:27 PM, Eli Zaretskii wrote: >> From: Tom Tromey >> Cc: Tom Tromey , tromey@adacore.com, >> gdb-patches@sourceware.org, palves@redhat.com >> Date: Thu, 18 Jun 2020 10:00:57 -0600 >> >> 2. Use --avoid=stat --avoid=fstat. So far this seems like the best >> approach. Pedro pointed out that this means we won't get any gnulib >> fixes for other bugs in this area. However, given gdb's relatively >> minimal needs from stat, and given the fact that gnulib is >> introducing other bugs, this seems like an acceptable tradeoff to me. > > If that works, I think it's an okay solution. I disagree. It's not only GDB's stat usage that counts, it's the other gnulib modules that depend on the stat module fixes too. Also, that approach disables the stat module for all systems, not just mingw. I think it's just bad policy to disable a module like that. Thanks, Pedro Alves