From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91098 invoked by alias); 10 Jan 2017 17:59:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91087 invoked by uid 89); 10 Jan 2017 17:59:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=wise X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 17:59:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8112B80F95; Tue, 10 Jan 2017 17:59:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0AHxZfm009220; Tue, 10 Jan 2017 12:59:35 -0500 Subject: Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command To: Tom Tromey References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-8-git-send-email-tom@tromey.com> <878ts2yi5m.fsf@tromey.com> <87inqletsw.fsf@tromey.com> <7f11b7bb-bebb-1cd3-1e92-266638272443@redhat.com> <87d1gmwk2j.fsf@tromey.com> <87h95u5sat.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 10 Jan 2017 17:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87h95u5sat.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00176.txt.bz2 On 12/23/2016 08:00 PM, Tom Tromey wrote: > Pedro> In some other local patch that I hadn't posted, I handled a similar > Pedro> situation of save/restoring some global that we don't want to expose > Pedro> by making the "make_cleanup_..." function return a scoped_restore, which > Pedro> avoids having to create a new class. It seems a bit simpler that > Pedro> creating a class to me, and maybe a tiny bit more efficient code-space > Pedro> wise (rtti?) Did you consider this approach? > > Tom> I didn't, but I like it, so I'll make this change. > > Here's the new version of this patch. OK. Thanks, Pedro Alves