Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tdep] Fix unrelocated pc in i386_displaced_step_fixup
Date: Fri, 20 Mar 2026 17:33:37 +0100	[thread overview]
Message-ID: <ce4aca52-37dd-4f64-8dde-00dbf58f9835@suse.de> (raw)
In-Reply-To: <87h5qc577o.fsf@redhat.com>

On 3/19/26 1:34 PM, Andrew Burgess wrote:
> I still see these failures:
> 
>    FAIL: gdb.threads/next-fork-other-thread.exp: fork_func=fork: target-non-stop=off: non-stop=off: displaced-stepping=auto: i=4: next to other line
>    FAIL: gdb.threads/next-fork-other-thread.exp: fork_func=fork: target-non-stop=off: non-stop=off: displaced-stepping=on: i=2: next to other line
>    FAIL: gdb.threads/next-fork-other-thread.exp: fork_func=fork: target-non-stop=off: non-stop=off: displaced-stepping=off: i=4: next to for loop
> 
> The first two are described by PR gdb/29040, but the third is a
> different error message, but I don't know if the third failure is a
> consequence of the first two failures or not.

The failures are independent, gdb gets a clean_restart for each 
different displaced-stepping value (on/off/auto).

But AFAUI, the FAILs are essentially the same: the main thread is 
stepping through a loop when a non-main thread runs into an abort.

The test name varies with were we happen to be in the loop at that moment.

Thanks,
- Tom

> Still I do think the fix
> you are proposing here is correct, so with the commit message cleaned
> up:


      parent reply	other threads:[~2026-03-20 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  7:19 Tom de Vries
2026-03-19 12:34 ` Andrew Burgess
2026-03-19 17:40   ` Schimpe, Christina
2026-03-19 22:34     ` Tom de Vries
2026-03-20 16:33   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce4aca52-37dd-4f64-8dde-00dbf58f9835@suse.de \
    --to=tdevries@suse.de \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox