From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SDNBEtsN2Gd3rRIAWB0awg (envelope-from ) for ; Mon, 17 Mar 2025 07:56:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LP/MC/wt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3960E1E0C3; Mon, 17 Mar 2025 07:56:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CD4321E0C0 for ; Mon, 17 Mar 2025 07:56:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93D413858031 for ; Mon, 17 Mar 2025 11:56:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93D413858031 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LP/MC/wt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B01BF3858CD1 for ; Mon, 17 Mar 2025 11:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B01BF3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B01BF3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742212531; cv=none; b=OjXufSGQsNdIR26xH3wZxKfP8/t1cvp0SuYLaX3MvllV4nGHOks7iVuvWX/SlsNK1nVxVUewVK4kfm+BFwcOdCvQHdarbvehbW1bk2iwiWj6pBrgaFOoJiHPXFBCy2WcLG1yIk/va7tqCTz+z76FVS02CvvsAkD6immk0lUOS8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742212531; c=relaxed/simple; bh=GoJf5XVhEPuURTBthrEY6asOIGqJ5xjfjM7yJmjf1zk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KzXyiyVP+8jR5NHLQdEcUMOc5xZnnI5HKC+v6GUTPZfwt8qeJu8sL4BkAHohkRbh13cUrvTA8zVAIcViqm76UiwWZQW+3fZNTM1RqFOBld/dp2p4jzu8WVdylS9vTKRpl9aS+rpPrF7SEnmNICMVRUnfzuLZBuxQa7B/Y5oXmzc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B01BF3858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742212531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMZ9IyFTJJLm5In7KVsQIZT+9FGVQEGPVmo6/ag5/9Q=; b=LP/MC/wtL2JYhUQJ3hsIjKTehjAxUAPPSkD2wUdogoSBrkMk1LkqhEhJJtXMciEOifFLyo HsLJvxJiEMRbER4gmSga+SV61ip4oEnjk2Ws3e+LiEv4Cx6wfeQ3mFe4mni/TlX+8GMFl8 2fP9F94XHiVSwVVr+TzDYlVY9yFARm0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-yeMI6ihzPHm-k6uNpOopJw-1; Mon, 17 Mar 2025 07:55:30 -0400 X-MC-Unique: yeMI6ihzPHm-k6uNpOopJw-1 X-Mimecast-MFC-AGG-ID: yeMI6ihzPHm-k6uNpOopJw_1742212529 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-22406ee0243so52171835ad.3 for ; Mon, 17 Mar 2025 04:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742212529; x=1742817329; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EMZ9IyFTJJLm5In7KVsQIZT+9FGVQEGPVmo6/ag5/9Q=; b=kvTxkPJLYm/xKMEbKTRHktWStE0HhIrGwCreAPto8NyNYypew5hcwXg+ZQ8Rl9IhDH rjQABDnuSjdpJ2Yvmwu8dv1lTXkogo+RDO1iuRCGvauVFVCC8S2/r736HRz/3leSiMzA 15KBr93ARj6gNOA2tf4VJb+p8sJyCzRO1IX9Vk/8RzNC5ZuUO7+8D17yzX03vXDgNVF+ 4/6stPbkDvrm0RWdvulmzwD+wdQyPqjoCRDk8FRcpSrY4h6CLlJ8nGNYMoa7amtVi+Ut SCqUwqUeppwVbI2mlGzLeY/J6Ksbep2QaIL3Dzbt+81OOeF8wwtXmOHR2umhNyS6hDp8 dbtQ== X-Gm-Message-State: AOJu0Yw3S1Ljk0mU4/AijeABtFsztl90ZWqFjSaU6UE3KsXDsc5ELHBX JpJJNIYEsbPZBUw58tMjiWeHh1qO5HOAgaJnJj/bDTfoz4ZxzwqVoC9qws/uIDVPywuXYGwbT1Z VCYWZQbQIzKBx5ZJ+ObpMC4AUHYy08c2qx9Ag6M6xAVwdbZWxBeVcfih2SNf79iT4j6I= X-Gm-Gg: ASbGncsSc+pMu/dPgjJAT7hYbfc72gfo94D3UAg762nVg56/28IHZSi4Z1JSu8lJ9cV HvmKKrt9PnNCCehqzU2qv3UtoSZntNEsTblFyP4g9Z2daSgzUpQpOIKRk/dIA2iFXpEgfNhW9IQ QmTuHKJZ93GrT6Iic8WRqjdhe6My8ahdx7u1b8n7VQYt+yqjEH1zhdDsJhG0OdHmfqfB2hisApo BdyDjaI8ZnQS318OJ4hV9E0sKInkQc8e2HpvIx8VjyPZuAlpzUwPxSqVWMfwWkX45P3Lnn7pzeQ Aq1CAbOv7K2Lh/PH26sIQbOANp8= X-Received: by 2002:a05:6a00:1955:b0:736:3ea8:4805 with SMTP id d2e1a72fcca58-7372235694amr13547771b3a.7.1742212528865; Mon, 17 Mar 2025 04:55:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0FuQyqqzq+qdlcj5fHBYS9Q+qCj1i3H8J5jKmzRG1JEKwxRpp1yr4xSFZ3L0Tjqb55oyamw== X-Received: by 2002:a05:6a00:1955:b0:736:3ea8:4805 with SMTP id d2e1a72fcca58-7372235694amr13547742b3a.7.1742212528424; Mon, 17 Mar 2025 04:55:28 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af56ea041e7sm5807322a12.44.2025.03.17.04.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 04:55:27 -0700 (PDT) Message-ID: Date: Mon, 17 Mar 2025 08:55:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared" To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250313170004.3362207-2-guinevere@redhat.com> <20250314195108.2c4891a9@f41-zbm-amd> <20250314201112.29c30ab8@f41-zbm-amd> From: Guinevere Larsen In-Reply-To: <20250314201112.29c30ab8@f41-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CrjguZjJK-tqs6nA1FMEF5A1JXZYqhafCCNeksI_4KI_1742212529 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/15/25 12:11 AM, Kevin Buettner wrote: > On Fri, 14 Mar 2025 19:51:08 -0700 > Kevin Buettner wrote: > >> On Thu, 13 Mar 2025 14:00:05 -0300 >> Guinevere Larsen wrote: >> >>> Finally, a new solib_ops function pointer was added, find_solib_ns, to >>> allow code outside of solib-svr4 to find and use the namespace >>> identifiers. As a sanity check, the command `info sharedlibraries` has >>> been changed to display the namespace identifier. Plus, a couple of tests >>> had to be tweaked to handle the possible new column. >> I applied the patch, built GDB, and ran the tests. But I didn't >> see the new NS column in any of the "info shared"/"info sharedlibrary" >> output. Should I have seen this column? (I.e, did I do something >> wrong?) Assuming that I didn't mess up, I think it'd be good to add >> some tests which show the new column. > So... I screwed up when attempting to resolve the "git am" problem. > I guess I need to figure out how to correctly use "git am --continue". > > I now see the NS column in the "info shared" output. But, now, I *always* > see it in the "info shared" output, even when there's only one linker > namespace. Is that desirable? I did that on purpose, as long as you're using solib-svr4 (which is the only namespace-capable solib handler that I'm aware of) you'd see the column. My reasoning was that when I didn't see part of an output that i didn't understand, I personally would just ignore it, but I wasn't sure my approach was the best. > > My opinion is that we should suppress the NS column when there's > only one linker namespace. I can give this a shot, but in my head there are 2 ways of implementing it: 1. If there is more than one linker namespace *active* when the command is run; 2. If there is more than one linker namespace *registered* when the command is run; The main difference is: if the inferior has opened an SO in a namespace, but has since closed it and everything loaded is in the default namespace, should we still have the NS column? The first is closer to a future plan of having an "active namespaces" convenience variable, while the second is brand new code that I don't expect to use anywhere else, but I can see an argument for it, so which do you prefer? -- Cheers, Guinevere Larsen She/Her/Hers > > Kevin >