From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34667 invoked by alias); 10 Sep 2018 20:01:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34650 invoked by uid 89); 10 Sep 2018 20:01:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=connect, rtos, Hx-languages-length:1108, talk X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Sep 2018 20:01:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w8AK1lYb004931 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Sep 2018 16:01:52 -0400 Received: by simark.ca (Postfix, from userid 112) id CD8CA1E75F; Mon, 10 Sep 2018 16:01:47 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D57AF1E16B; Mon, 10 Sep 2018 16:01:45 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Sep 2018 20:01:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: gdb-patches@sourceware.org, Jerome Guitton Subject: Re: [RFA v2] arm-pikeos: software single step In-Reply-To: <1536604744-3814-1-git-send-email-y> References: <20180910174345.GD3234@adacore.com> <1536604744-3814-1-git-send-email-y> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00302.txt.bz2 (not sure why the From address is y@eu.adacore.com, I'll replace it with Joel's). > + symbol_table = (asymbol **) xmalloc (storage_needed); > + make_cleanup (xfree, symbol_table); It would make Tom really happy if you could avoid introducing a cleanup :). I would suggest using an std::vector. If you'd rather not do it it's not a big deal, we can change it after. > diff --git a/gdb/configure.tgt b/gdb/configure.tgt > index 6d1a4df..a1f703f 100644 > --- a/gdb/configure.tgt > +++ b/gdb/configure.tgt > @@ -180,6 +180,7 @@ arm*-*-symbianelf*) > ;; > arm*-*-*) > # Target: ARM embedded system > + gdb_target_obs="arm-pikeos-tdep.o" > gdb_sim=../sim/arm/libsim.a > ;; The object should be added to ALL_TARGETS_OBS in the Makefile, so it's included in an enable-targets=all build. Just to understand better why the object file needs to be added here, what is the target triplet? arm-pikeos-something, arm-none-something? Just wondering: when you connect to the target, you talk to a gdb stub that is built right into the application/rtos? Simon