From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54186 invoked by alias); 4 Oct 2016 18:37:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54170 invoked by uid 89); 4 Oct 2016 18:37:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=BAYES_00,KAM_STOCKGEN,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 18:37:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE6C5285A5; Tue, 4 Oct 2016 18:37:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94IbEhI018584; Tue, 4 Oct 2016 14:37:15 -0400 Subject: Re: [RFA 1/3] PR symtab/20652 - fix psymbol_compare To: Tom Tromey , gdb-patches@sourceware.org References: <1475531646-18049-1-git-send-email-tom@tromey.com> <1475531646-18049-2-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 04 Oct 2016 18:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475531646-18049-2-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00059.txt.bz2 On 10/03/2016 10:54 PM, Tom Tromey wrote: > @@ -1577,7 +1577,7 @@ psymbol_compare (const void *addr1, const void *addr2, int length) > struct partial_symbol *sym1 = (struct partial_symbol *) addr1; > struct partial_symbol *sym2 = (struct partial_symbol *) addr2; > > - return (memcmp (&sym1->ginfo.value, &sym1->ginfo.value, > + return (memcmp (&sym1->ginfo.value, &sym2->ginfo.value, > sizeof (sym1->ginfo.value)) == 0 I wonder whether using memcpy is really the correct thing here, considering ginfo.value is a union. I.e., thinking about padding bits not part of the active member. Maybe we're zero initializing the whole value and it works in practice because of that. > && sym1->ginfo.language == sym2->ginfo.language > && PSYMBOL_DOMAIN (sym1) == PSYMBOL_DOMAIN (sym2) Thanks, Pedro Alves