RE: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining

Andrew Burgess
2024-09-23T10:41:20Z

"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com> writes:

> On Friday, September 20, 2024 9:11 PM, Guinevere Larsen wrote:
>> On 9/20/24 3:55 PM, Tom Tromey wrote:
>> >>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>> > Keith> On 9/20/24 9:20 AM, Guinevere Larsen wrote:
>> >>> I've given some more thought and I think a couple of comments could
>> >>> help anyway. Here's my suggestion, thought?
>> > Keith> I am pleased to have an explanation there. Thank you!
>> >
>> > FWIW I read through this and it all seems fine to me as well.
>> > Thanks for your review Keith.
>> >
>> > Approved-By: Tom Tromey <tom@tromey.com>
>> >
>> > Tom
>> >
>> Thanks, pushed!
>
> I'm sorry to chime in late. Just two comments, in case you'd want to consider
> further edits.
>
>>> + {debug c++}] == -1 } {
>
> It may make sense to rename the file extension to .cc.

Also, maybe if the test is now just C++, wouldn't moving it to gdb.cp/
make sense?

Thanks,
Andrew

>
>>> + int res = foo ('1'); /* Single-location breakpoint here. */
>
> For a quick reader, changing the argument to 'A' may make it more
> apparent that this is a char.
>
> Thanks
> -Baris
>
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928