From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93913 invoked by alias); 24 May 2016 15:59:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93903 invoked by uid 89); 24 May 2016 15:59:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:990 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 May 2016 15:59:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6644552D3; Tue, 24 May 2016 15:59:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4OFxRnp022706; Tue, 24 May 2016 11:59:28 -0400 Subject: Re: [PATCH 1/8] Switch to current thread before finish_step_over To: Yao Qi , gdb-patches@sourceware.org References: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> <1463757161-25850-2-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Tue, 24 May 2016 15:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463757161-25850-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00426.txt.bz2 On 05/20/2016 04:12 PM, Yao Qi wrote: > This patch switched current_thread to the step we are doing step-over s/to the step/to the thread/ > @@ -4741,7 +4749,13 @@ complete_ongoing_step_over (void) > > lwp = find_lwp_pid (step_over_bkpt); > if (lwp != NULL) > - finish_step_over (lwp); > + { > + struct thread_info *saved_thread = current_thread; > + > + current_thread = get_lwp_thread (lwp); > + finish_step_over (lwp); > + current_thread = saved_thread; > + } So the pattern should be that if a function takes a thread/lwp parameter, then it should work with that, instead of relying on the global state. So I think that it should be finish_step_over itself that switches the current thread, because it is an implementation detail of finish_step_over that is calls into functions that rely on the global current thread. Putting the save/restore there should make it more obvious why it's needed. Thanks, Pedro Alves