From: Pedro Alves <palves@redhat.com>
To: Alan Hayward <Alan.Hayward@arm.com>, Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] Testsuite: Ensure changing directory does not break the log file
Date: Fri, 22 Feb 2019 14:21:00 -0000 [thread overview]
Message-ID: <cd66e19e-3893-a685-97b6-4fc45c761434@redhat.com> (raw)
In-Reply-To: <CB2D111D-BDC5-49BA-B3D2-E9D96E3FABDC@arm.com>
On 02/22/2019 12:36 PM, Alan Hayward wrote:
> +# Safe version of cd that ensures the log file is not stopped.
This comment seems unclear to me, if you don't consider the email context.
What does it mean to "stop a file", for instance?
How about:
# Override the 'cd' builtin with a version that ensures that the
# log file keeps pointing at the same file. We need this because
# unfortunately the path to the log file is recorded using an
# relative path name, and, we sometimes need to close/reopen the log
# after changing the current directory. See get_compiler_info.
> +
> +rename cd builtin_cd
> +
> +proc cd { dir } {
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-02-22 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:34 Alan Hayward
2019-02-21 22:40 ` Tom Tromey
2019-02-22 12:36 ` Alan Hayward
2019-02-22 14:21 ` Pedro Alves [this message]
2019-02-22 17:10 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd66e19e-3893-a685-97b6-4fc45c761434@redhat.com \
--to=palves@redhat.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox