From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5387 invoked by alias); 27 Apr 2018 18:07:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5372 invoked by uid 89); 27 Apr 2018 18:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Tested X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Apr 2018 18:07:30 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAD304025F12; Fri, 27 Apr 2018 18:07:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 571FB10B2B42; Fri, 27 Apr 2018 18:07:28 +0000 (UTC) Subject: Re: [RFA] Enable -Wsuggest-override To: Tom Tromey , gdb-patches@sourceware.org References: <20180427140734.8540-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 27 Apr 2018 18:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180427140734.8540-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00573.txt.bz2 On 04/27/2018 03:07 PM, Tom Tromey wrote: > I noticed the existence of -Wsuggest-override and so this patch > enables it for gdb. It found a few spots that could use "override". > Also I went ahead and removed all uses of the "OVERRIDE" macro. > > Using override is beneficial because it makes it harder to change a > base class and then forget to change a derived class. > > Tested by the buildbot. Yes, please. OK. Thanks, Pedro Alves