From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oaCoGzTthGnPIyoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 14:19:16 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VNv88kno; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6CF4D1E0BA; Thu, 05 Feb 2026 14:19:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CA1161E08D for ; Thu, 05 Feb 2026 14:19:15 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5C2A74BBCD81 for ; Thu, 5 Feb 2026 19:19:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C2A74BBCD81 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VNv88kno Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c104::]) by sourceware.org (Postfix) with ESMTPS id 9DDC04BBC087 for ; Thu, 5 Feb 2026 19:18:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DDC04BBC087 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DDC04BBC087 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c104:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770319129; cv=pass; b=ingZSwvJdM8AvAW9P8e4C0ALqI2uNpT6+Zh/Zx2W4Ot4RwWaiq0Y7QPDRaVsxS9iQ7jAe7bW9VTd0aFVDlEHNOVwZ7TZWGJ6Z4KiKZ0O/ICfELv+rAuIIy1jie6+EUmIOxRRUhiZPPT+4GEmVZCG2NqzFJuXTEcpnAI9UKOm7bk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770319129; c=relaxed/simple; bh=v+ZVKyqnXb5IkiGsSm9GiRxF2LtOaP8FmOh9LEbtBSg=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=tI2iDLLUVFtE3qcN5+7fjiK6yOVf0szqbuNwi+Tnl52CntXp01Jyk3DeOHHWLeK0DGW40/XmbyABCNQLtgQhvh/DaD1nEWYtmtbWzIDjzZdM+BTrm0sqMZolEdgkGeCk3argP7L7aWY7ykyhTjpL6lH47k49MK5jPFVw6CREHj8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DDC04BBC087 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IqYaj57GHTh3cJWoH1917fc0RtKpBM/VsbAwV8LtAiIffFc35Yn7HnJUPg0TbOQrPHMi7dgZxF32sDQ6tJmwuc1FU+9hSMvXHGxhQsw6YmwGaU7x9r+bjkU/vRDHgeZPidxzQpUFkKcEax+4Cg3mWTeVO8nDtfLG5dYb4FoZFQLv+kKM2vZGsPR9xGmx2IM5bL080mtI7YOOB1NxrcRP+rBRmtsQC1/tsVAc47MKjzEa/s5zU2GDcSCAAoyD763jbn3C4x7CfU+SoCT8LFOA7hpcGOtEBCuANv9LeJDMuky4gldsxTTMPqBajwl/0RPpTTie6OLti6Oxug9Mqc7unw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G920nzuUa/cR/G1nf/tEI1OKa5yM2Ym/+IUcTRML8po=; b=q4e9dbPCNtpoTCrjHbn/dlBpCxc9e4PYaAXw23i/Ai/Fvd9IesLaGxeQPdiuWEtyZfZBeqRLZf8mQ5wniepqwgcYci7/E1Es5oh5ds5mXgfzlqsdQwaNOsdAEkByKEHogB3LxzCHt3iqb1Mvjq7CS/4W79v96hzQlUWSsdatjpVdOk3CXEue60YNUxwWlGk40TUpSR4WGzeDiNAGvbeKrpG8pH0S0vuTn1pY3O4z8IrKyYRXDR3iVYAMCDt7UU/WwoJEoW4FVWHYKxFdqBtcJFk4wc/W38636Db8l+57qUjNW1LW6Q8+Xh3LagvXuZQkSWvuvAOPMYAP2ANV+7ZYSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G920nzuUa/cR/G1nf/tEI1OKa5yM2Ym/+IUcTRML8po=; b=VNv88knogOp9Dxpt4xrGaVVvPw4SoKLFZ0q4+w45EviZ/+khXL+G6AWYvv/NKNaC2oLrMUTNX94wFYfCeN8IKhTRL+eZNay/suOOvaq/JLK/tpk/KFfvfGMS0VpMOdoynWkZOcrQwuq3NJ0s8OLf5/VPcLTmdzoxgz2EHNLuq8wL09ZGLmxUiRp+3WZCit8k3ID5fv4tXEAi+HwShYDkv7IZ/rGO28zZR74dtfMnOIjHQm6cZgnf938qh8XR5ggjlrdKAIUdBQoKiNvFbqXL/9qelbd8CkSVRIdeIspTO1brK/l/FD2hVwThdDTrgHPAaDsJTcech5nIf0nYRiglRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT1PR01MB8331.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.14; Thu, 5 Feb 2026 19:18:41 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9587.013; Thu, 5 Feb 2026 19:18:41 +0000 Message-ID: Date: Thu, 5 Feb 2026 14:17:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator To: Tom Tromey , simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org References: <20260130025546.322629-1-simon.marchi@polymtl.ca> <87pl6j58pp.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87pl6j58pp.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT1PR01CA0147.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::26) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT1PR01MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: 7432ae3f-30a5-4774-2ab9-08de64eb5f42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aXZJUnlIRktoY3pzNGtaT3FLSXJCN0pZR1V2UkpBZzhaOUI3RHY5bFV6TDBh?= =?utf-8?B?T0xpd3BFV25KRlJFWVlrUjMwb2hCTHB2UEhuR2dRelV0TFd3dXpRSjM5bUMx?= =?utf-8?B?U1FIUzhGUlJLSUgwUlpPSE04dGVjNUVySktncitNMzh2R1Foa1hBZlVFWDBo?= =?utf-8?B?QTNmUTZLelMvTVFZOUhqNFhod3JwRm9McnJTTGowdG1MMGpTN3RTWWV2UGNv?= =?utf-8?B?MzFQbFNOSVloTGNvSDZvcHlkRHk3LzN2bS9Cc21FYStrcENvbDk1MGZYL2hK?= =?utf-8?B?SHo4eldqVmlSdkV6dnQzWVY3VThJMStteUdpSG02QU4rMnVCL1FmYmdjQm9R?= =?utf-8?B?cWdRNnMxRVQyQ3VZSHpVK0g3alBlOExRZ1dsdkR1eFp5b0hBRVZ2QW15MVZC?= =?utf-8?B?c3BUZkdaNTEySTJKT0YyZFVNODIybENjRVlhUFpGS0N1SVEvaTBFQnU4a0xa?= =?utf-8?B?dFpzUUd6UW5TQTdBNTF4c1dWdklrRndpYzFPRmM3MENWZE9maUF5bDNhaXlR?= =?utf-8?B?NE1NaE5RdGVsRmRHVDVHU1hjSzExZVJ0REJ5eXFOTXJVNThkMityMWRCT2Y2?= =?utf-8?B?dEc3STRSQVRlNEZrQTVQcStaN3VrRU1vd21sbGl4eUxZRURnd1VaZVVyY2VZ?= =?utf-8?B?cFRFV1U0TW9pUUx6WGswcjlGcjlIbDk1Z3lkRjYreU9Ibi9mVlJTVGxuWG54?= =?utf-8?B?bWZRWUtRSXBUeEQ3V3kxbi9kakxPMEhxT09nOTNVOUVVM1JzbUZhTUFBTFJs?= =?utf-8?B?VnBveThOZ3VMV0o2WHcwaklVUnZFQVJmb1VoOWVpc1g4TzJlQ3ZCdkErT0Ew?= =?utf-8?B?STR4NnlzU2NFQm4xeTQ5Ty9PZUVTRWEwKzhYayszRDNEQm0xOGU4a2VLWUFX?= =?utf-8?B?Mmg2ckVBRGlkSFcvVTg5eDROVlJhMjVHQTltQWV2R1ZDRnpqMFJuUkhMS0xV?= =?utf-8?B?OEVmajBrK1ErRXUyc2ZZWFMzZEdCNy9SaWFqT3lXZTN1RUROblYvNTF6Mlli?= =?utf-8?B?YTZXQnYwVjkxb1hFRFhZZi91b0VzWE1GNVBGaDU5K3RrMGJ0eUNZWHlyNy9w?= =?utf-8?B?WTBTOHdUbVFSYXB4ZVRxaUtXRG5CZk10aktDTVR1bFN5UmNBa0QxcGNBMzZF?= =?utf-8?B?RGdZUjJ5a2V4TGJoZDVCZEM3WjhlY2d4eVdPcGlrbFJwclAzdDEvMXFSdldS?= =?utf-8?B?Njkwcm9SRFJJbG9tQ2U0RmxIZklVZEZqYWZsRnl4cWRZQjh6LzRYUVlqRHA1?= =?utf-8?B?Z1BnZGxnMHZuWnJqS2hzY2duUWl6VmpBM2dhWUhsdEJKeDBQSTJ4ck1vdlNw?= =?utf-8?B?a3dudHBuWUJiRnNlRzQrZVhJQXhCZnFUSTc0SGNrKzJkTGlLV0FZUEkwUERn?= =?utf-8?B?V0U4bWc2V0xIWVloVjB0WUZjZ2NYd2pBSXNKd0diT3RtZ1lDMmdNWi9DUDhI?= =?utf-8?B?WUd4ZlQxMklWdlMyYjIydFRsd1JkUkNqSHptV2lvOUJqcnpLdXNKL0Mxcm0w?= =?utf-8?B?dGp6c0U4aXFuYzFLVVBkYjNUS0lrNkwwRmRVK3RSTWJqN2J0RVoyQTQ1VnBU?= =?utf-8?B?cnY3L0xZbXk5Tmk2OFpNODRldXYzcVZPVlNnWGJLQlRyWkVIRlJlQXRXSGx5?= =?utf-8?B?eDZJYlQxR0c4L2x4WE9QYittOW90anNmZGRTSlpvYmgyMHVaMWhGSkpFZ0Fk?= =?utf-8?B?eXhxK2ZRcXhZbEhTUlJjWnlSNWE3dnBWRk81Mk5UZjlrWWJOVG9FdUlOMWdu?= =?utf-8?B?NzJqbktjbklvNE5jUEhnUjJTQmVmSVZVRjAvc2pWOVZKWWZMejRXQk9JbFI3?= =?utf-8?B?SUpsemZ2aVBMMlM4bVFaSldPWVdZNjJ0UjRuNFArcjJmYlNKb0F4UkVwajNi?= =?utf-8?B?UFR6M0FFRnYzT1pleW1oYmlWeE9IUXVPeDI3b2RHa2ZqVS9jay9McDlHdGho?= =?utf-8?B?RlhnaG0rV1RiYWprVUtaRE1hdjhxaXJaQjBjMjU1WUgrTmxGelIyMkp5ZWUr?= =?utf-8?B?cmxZdWtxOG5jT3lpSFBGVjZZd21URWJNVG9uZmhZbkc0NW5tZk5iQm0vS0or?= =?utf-8?B?Ni8yZTJaSnhJekxxQm9hRysyZGpiVXptR2ZNZnRqc1hZTTJNaXBsNWZ5L2pI?= =?utf-8?Q?CmWg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGRHYVBLY05LYlFFbEhCV3BkeENwNUdZem1JR0taR0pTTWdzRXJ6SnFVMG42?= =?utf-8?B?bDdvaXIxUndCWVo3ZUEwQm9mWU9ET0lwVE1nK2doblVFcUJkTzFGR0Y1MXpw?= =?utf-8?B?MDl2d1FHeGYwVExoNUpqalJkdXp2UE44MWhKKzN4NzNBOHpGV3U1bVNUMisw?= =?utf-8?B?dEFBVFJPOE1rSitoTU4rcnpNRit0RDkrK0hVZ1hlOUZyWmhkNzZTQjEwTEwr?= =?utf-8?B?TW5JVTYzVWp5VHhCR1ZObFBzZnFUMkh3eWdvbjhleFcraHRGay8yVmNwMWtw?= =?utf-8?B?cUJESHRPRHQwODJ6L0NtODVYVnBkdDcxZEJJM1ZKUDJvbFd6eUJCYWhJYktp?= =?utf-8?B?cnZka3lzeUx0MUFRUlBhaXRUODduYlhNVFBKd29IL3hrb1U0bGxIdndVbjh3?= =?utf-8?B?Y0RYN2FSUjl3RkZrOWhHOE5jeTkvdk02SXptZDc3aS8zK2FBanVEZmlTSWl4?= =?utf-8?B?R0NTbExDQ3FFNEpnSW1mQm8yckg3ZkRyVXpiemYwZXBSSXErUDJyNUU2MmJw?= =?utf-8?B?cFBxRVprSVNCVlprVmtWTjlsdGhiWXVnOU5ORHYwQmRhd0MrWDk1Zmk3cjFU?= =?utf-8?B?S2xBbk82VHVYV0NobCtFMDZKMW5qRU9DcmRCS0s2enhjQnc2WVlGRERWQWh5?= =?utf-8?B?S0sxQitlcVlIbzVJWGx2WVJkeXcxVFZQUzRiVGk0S1p4VTBOSTd4aFprTUFM?= =?utf-8?B?K0I0QmlPbU8yelBBM3dRQS9WZUpQQXAxVmdvbFhGTmN6WUFPRkszb1Zwd2Zz?= =?utf-8?B?TVhwY0RLUVU5YVVxV3NJSGZKS1NSUGUxd0EycDErNzgvQzdqYWhqRnI0Nkdy?= =?utf-8?B?dm9rYmNPbkEyTW0zMm5UUTUwTFBsK2NuaWlWVjZnQnNkNzlBb0JrY1dJWWw2?= =?utf-8?B?WjNpbFBFWFRUU0R1MXZEMkZ3VDRkek5uOEQ2bmtUNCtXWE1YZko5UlJrOWNq?= =?utf-8?B?NHlPOWtPL0h1b09SUlhsamZ4UlM0MFhIWlhlamN1ODRuWWs2TGM1dGpkR3M3?= =?utf-8?B?ei9uZUhTMDJaVWo0YjhQUnFvU25JVzltSklqZFdHeVdUdGljQllDM3M0enM0?= =?utf-8?B?dVhsb1dpY1NManQxYmdXaU1EcEpEc2w2RzhhUjZtZ1AyK2w0WUZMUENGamFF?= =?utf-8?B?S1JOOXU2MHBBUzJCR2JhQ2xheXBuWVZmQ1RCL0ZEVmRwcmk0UmJtaFhGM0Vm?= =?utf-8?B?TlFmMjNvOThET2x0UWhMSWRvMkRxZElrbmQ3Z3B3aGNOZU8vcmVVbnhGMkk0?= =?utf-8?B?T1ZLOU4wUjVTcGRoeUZkY0xKdm1USmpMRStTSEs0WGI4c1ZINWRWcTZwblBV?= =?utf-8?B?SmczM0s0T0Y0YTEvUk45N2I0VGlkcnZCWVgrWXhCOURabjZxUXlVaXhOYUxz?= =?utf-8?B?NXk4MXk0OEQ2RFkrTGF5MTNPRWJSb0dHcjlvR0p0TXJOdk9GQ3J1d2ErWmNZ?= =?utf-8?B?dEdsTDdvU1FZSjdDbnpTNXRMMGZPN1hYWFF4bXRZV0lua295bDZ1SVNJV3RX?= =?utf-8?B?WkIyQy94a05aVFBCd01YSm43Q0VVMkxabGZ6RVZrVUpQSUpOenNsb2Q0bW5B?= =?utf-8?B?ejJwcmx2cTAwZ0hKS0dFRGx0UG02WS90QmMxbnpVNzF4aDRhelV1bi9lWDBQ?= =?utf-8?B?Qm9EWVphc3A5VFY3ZDNPYitBVnh4Z2h6dytZZm91UnpNYmkvdXFvZld6N29V?= =?utf-8?B?Nml0ajlhV3lSdHlJS1ByYmFlSlR5NlpKL0IxV29YbHhpZDFmem8xNEJ0Rlo4?= =?utf-8?B?MGhMazJXNDR0dUxTU2J3N2UyeklobmVkeGh1clk0QU9DM05TT1JtQUc4RUox?= =?utf-8?B?Y1UxeEZzZkpNR0dUZlVyL2Z5L1lJMjNoQXgrVzBHT1kyTWFIUUZDQmdYQkRI?= =?utf-8?B?aE5zdDZLNEJoVDBPVFBHZFVQTjl5ZUtLZEUxTTRYMlZucXJOSmcweng3L3Bh?= =?utf-8?B?MGR2WEttV0o0ZUZIT2o3NlJMcEowV3YwWlNHZ0RWOTBUVUM2SFVLTnRhTVJx?= =?utf-8?B?eDZ0ZVdjYWE5cVR6dVcvK0RwNm00NG92dGdYUkhSanVVeHJkdTJnQkkxbnJt?= =?utf-8?B?NnpiRlNhMFhTZUZjUExpWDhhaVVQS0I4dE92U080WjFJVUJhZVdjbmc5R1k1?= =?utf-8?B?OTQ2S2dobTM0YTAyMkNXaTk4eHFjUlhmM1VpL3RKY0JjNFB5Q29RZDEyemdn?= =?utf-8?B?dTFEZ3hrVnpPQnFsUEdoOXpJUmxXVzRXbVlTdHE4N3FEWTI4VHk0QU1EdVhG?= =?utf-8?B?Vnhsc25sZEJkenkwdjdUQjdzWFM1Qm0xM1NDcWxHYkVKOFpMd1NES0hyVzdD?= =?utf-8?B?Tll1b3YvOUxVQit3U1YxRDJ2ellKZE1VREF1M1RVUzJkaTZlbzVtZz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7432ae3f-30a5-4774-2ab9-08de64eb5f42 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2026 19:18:41.3024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aR8Bnrln+zlMEhb4QkG/eXGdVYDiB99qlmjrenaUWNx/dAcwYeEyIvSnX5O5GJrozHzEpaLdRz0cti3q9dNo+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8331 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/5/26 1:46 PM, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> +compunit_symtab * > Simon> +block_iterator::compunit_symtab () const > Simon> { > Simon> - if (iterator->idx == -1) > Simon> - return iterator->d.compunit_symtab; > Simon> - return iterator->d.compunit_symtab->includes[iterator->idx]; > Simon> + if (this->idx == -1) > Simon> + return this->d.compunit_symtab; > Simon> + return this->d.compunit_symtab->includes[this->idx]; > > I just recalled that block iterators work in a funny way -- they can > either iterate over a single block or a symtab. > > And, if iterating over a single block, then it's invalid to refer to > d.compunit_symtab. > > So I think this new method should probably assert like > > gdb_assert (which != FIRST_LOCAL_BLOCK); > > See the comments in block_iterator in block.h. Yeah I saw that, but I didn't dig too much. Because it's a functional change, I will send it as a separate patch. Simon