From: Simon Marchi <simark@simark.ca>
To: cbiesinger@chromium.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add gdb::nullopt, from C++17's std::nullopt
Date: Tue, 19 May 2020 15:15:34 -0400 [thread overview]
Message-ID: <cd0c5eb4-888a-b264-0e2b-db37bf9e9135@simark.ca> (raw)
In-Reply-To: <20200519185537.87677-1-cbiesinger@chromium.org>
On 2020-05-19 2:55 p.m., cbiesinger--- via Gdb-patches wrote:
> diff --git a/gdbsupport/gdb_optional.h b/gdbsupport/gdb_optional.h
> index 02a87f6ee4..d1e70e4be9 100644
> --- a/gdbsupport/gdb_optional.h
> +++ b/gdbsupport/gdb_optional.h
> @@ -25,12 +25,17 @@
> namespace gdb
> {
>
> +struct nullopt_t {
> + explicit constexpr nullopt_t (int) {}
> +};
Formatting of curly braces.
And as mentioned on IRC, there are probably tests in gdb/unittests/optional we can
enable for nullopt.
Simon
next prev parent reply other threads:[~2020-05-19 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:55 cbiesinger
2020-05-19 19:15 ` Simon Marchi [this message]
2020-05-19 19:27 ` [PATCH v2] " cbiesinger
2020-06-02 20:27 ` Christian Biesinger
2020-06-02 20:39 ` Simon Marchi
2020-06-03 9:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0c5eb4-888a-b264-0e2b-db37bf9e9135@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@chromium.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox