From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a VEC from record-full.c
Date: Mon, 11 Jun 2018 00:28:00 -0000 [thread overview]
Message-ID: <ccf81e9d71ecd23e88bae9c0873896eb@polymtl.ca> (raw)
In-Reply-To: <87in6qch4e.fsf@tromey.com>
On 2018-06-10 20:16, Tom Tromey wrote:
> Simon> Maybe I'm missing something, but it seems like the
> Simon> record_full_breakpoint objects are never freed. That's not
> related to
> Simon> your patch though, so your patch LGTM.
>
> Tom> Thanks for noticing this. I think this is a good opportunity to
> fix the
> Tom> problem, so I'll take a look at that.
>
> How about this?
>
> Tom
Thanks, LGTM. You can get extra credits if you make the
in_target_beneath field a bool :).
Simon
next prev parent reply other threads:[~2018-06-11 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 2:56 Tom Tromey
2018-06-09 12:11 ` Simon Marchi
2018-06-10 15:57 ` Tom Tromey
2018-06-10 21:16 ` Simon Marchi
2018-06-10 22:35 ` Tom Tromey
2018-06-11 0:16 ` Tom Tromey
2018-06-11 0:28 ` Simon Marchi [this message]
2018-06-11 4:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf81e9d71ecd23e88bae9c0873896eb@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox