From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rwffBf7pMmoBQgwAWB0awg (envelope-from ) for ; Wed, 17 Jun 2026 14:39:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E8ECF1E098; Wed, 17 Jun 2026 14:39:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7F5851E070 for ; Wed, 17 Jun 2026 14:39:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A0374BA2E33 for ; Wed, 17 Jun 2026 18:39:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A0374BA2E33 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 835894BA2E0F for ; Wed, 17 Jun 2026 18:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 835894BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 835894BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781721569; cv=none; b=xwFL1GH8pTJCiOyak9iM7M7BeMYIbPoyBfbAivZsxHl6JOsqkSBaodD7gdz/cDFRJgRIPH1DgF74xtW6uD+OrhUuPY/pgeAw+rBNcWnDamWIneF6B8Iux0gLSGAGJ08A9JoEbm7JpE//iiGergbVPrABCG1ZBQS/6SbwEV3t+6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781721569; c=relaxed/simple; bh=qPLaM4tZiGevrCXhGNkNVSxeLD1rav2K1vqYczek7z0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=YaHqHxmQxUEmZgKf2Br4/8pdIt8mUuvOAMX1GPmLm/smmB0rZP4X6ECbJkrG7m5xqWAtUWzpQwc8aAOS4/6/JFOZOuZwU4xu6bG62Y9Fx3J+BKwMToK4U6k2XII4fNn+MG8LdAKjmVwzFhbgSW6l7BPxKP+/tvd/8VYCzQmsEmE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1r0AG75t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vn/ZK5qd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 835894BA2E0F Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 344E66C306; Wed, 17 Jun 2026 18:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781721568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzV48k8DWriqIHPt5W5kkBPrZo+b4aWHBK/bh4fF9QE=; b=1r0AG75tZmUa08csL9uVeo8LNa7DTPBh8WhBl3nkxXUgmBxXDXXsx/FvzMofj7znmlAYrd 5HlGerqQbdn9lH7doLEQ1DJ0IuJoD6HJGaSXIddHAQyEuOKiaViEY9VMLCKNd1jnGNOjZa /359MYVlkQl3hdKbSLzV3DthZjZeyQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781721568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzV48k8DWriqIHPt5W5kkBPrZo+b4aWHBK/bh4fF9QE=; b=vn/ZK5qdixuRcWeoAd4Qy8GKZt6r0PQ4g86f1wsdqqcoc5gp3DXgg+fymEaS3DstpiglXs +bsMxtvHw95hCfBw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1r0AG75t; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="vn/ZK5qd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781721568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzV48k8DWriqIHPt5W5kkBPrZo+b4aWHBK/bh4fF9QE=; b=1r0AG75tZmUa08csL9uVeo8LNa7DTPBh8WhBl3nkxXUgmBxXDXXsx/FvzMofj7znmlAYrd 5HlGerqQbdn9lH7doLEQ1DJ0IuJoD6HJGaSXIddHAQyEuOKiaViEY9VMLCKNd1jnGNOjZa /359MYVlkQl3hdKbSLzV3DthZjZeyQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781721568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzV48k8DWriqIHPt5W5kkBPrZo+b4aWHBK/bh4fF9QE=; b=vn/ZK5qdixuRcWeoAd4Qy8GKZt6r0PQ4g86f1wsdqqcoc5gp3DXgg+fymEaS3DstpiglXs +bsMxtvHw95hCfBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1C529779A8; Wed, 17 Jun 2026 18:39:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t/GMBeDpMmqQGQAAD6G6ig (envelope-from ); Wed, 17 Jun 2026 18:39:28 +0000 Message-ID: Date: Wed, 17 Jun 2026 20:39:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [pre-commit] Add file mode check To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260605112118.854544-1-tdevries@suse.de> <87eci55aqu.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87eci55aqu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 344E66C306 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/17/26 7:37 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> +git ls-files --stage -- "${no_exec_files[@]}" \ > Tom> + | (! grep '^100755 ') > > I was curious why this check in particular is used. > Is there something that would ensure that an executable file would only > have this mode? > Here ( https://git-scm.com/docs/gitdatamodel ) it says: ... In the output above, Git displays the file type of each tree entry using a format that’s loosely modelled on Unix file modes (100644 is "regular file", 100755 is "executable file", 120000 is "symbolic link", 040000 is "directory", and 160000 is "gitlink"). ... So yes, that seems to be the case. Thanks, - Tom > thanks, > Tom