From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hjpLKegqh2qzjDIAWB0awg (envelope-from ) for ; Thu, 20 Aug 2026 12:27:20 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=o+8NItuC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 948EA1E033; Thu, 20 Aug 2026 12:27:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBDCC1E033 for ; Thu, 20 Aug 2026 12:27:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BD6A4B99F75 for ; Thu, 20 Aug 2026 16:27:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BD6A4B99F75 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=o+8NItuC Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170110005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::5]) by sourceware.org (Postfix) with ESMTPS id 35B7C4BAE7F3 for ; Thu, 20 Aug 2026 16:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35B7C4BAE7F3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35B7C4BAE7F3 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1787243197; cv=pass; b=ExrX/nqEaXa8wleLni1O4JbgO3WqJEariLoXVRWzu7vDFla3SHRljOsnzU7+3G10Ii1RoA/TAF0DVw8R0DwD6elFhMwew/OIrkEeIV2d9uNFAhAM5aeJV8/nLuglCuScdCrbynyFda0xrgMk2X3mCNLkH9rUtcD7ayewzfEdZZg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1787243197; c=relaxed/simple; bh=vaq7ewZfOcmfpv9Rl16eFT2SRMQ6hsOdlEYiQ88e81w=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=cUH33SecOGG7Py4R8bCzWAlrdbK8yIh6MnLKpNVNTynrum/qQ9Mo0FH/GDDiKPW0aTxCCGVk+pzW7JZYBw7StnZa9okh4CAV1U2M1Ttbp02EgEtR/1Obk590vzBOrA2exaBeltIS/cLuncZRL81ZSjtTgYbEGfvLRZT5HwgjHu4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=o+8NItuC DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35B7C4BAE7F3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fvt96w87k6K+w71eX+1e7r0D61o2XiqSUw1qzB5CJXdg83OgPVh4kkz6KTqQqGlpOXkYTZUQv75BqBoRv/Uqa6Zof3NQLlwPCqmXEqGemDWCjq6ULCa7uZE6qJhbJHUiuTcqWalX1Yk1HFuYoK+uEl6UV10WgR7EmYxArDFEjHuafrl/2xtL0xvFUBiImEiFDplXVq6mpxoyInOfZ0rYg3nidF5HkNsssL2mSfpIBkEhjNzo99OZvxfGgjZvBYBF5fdHFjmQxVwHRlKdDulK2hzeVRmFpaG9FdeEwOYrsimmr+M4pFve1cEpKQ9cmAQlHmSkpbFAvbCLu9RxE9uGAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKBV3crP9IbQvDY8S/UrmiFswGU8HNjrfV6lfHgqqtM=; b=ZM4CrUD8KLPgS5WVfyfff+CC/I23an6CSGfOpyAJScUP8dgHfl7DwrNKaPs2H7zjUP5WRIwty03tPm2NKqOYSrt2p0Wu+CCZIC5Y0yTOBqXzM7Mfswq8nBGdL2bQJM5L2vNZ7n6FFrWRpgUq41SIyoycd+4Qqzj70WtVF1c4CIp8AJX49+amvTy4bE07NPCd//sRWSy/hrPYCm2b2HdGAhfITnIm3ZqoyrhRT3FRm1ux/AD2NJ7DNmcxjsyc56quN3ggaog6wwAiJoUgoh2L6HAfrhH+W+gX0ZKsbjtHdUEXNhFtqGFeuboI75hRvJHd/y6I+oVGWrwieSJ4GGi8Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKBV3crP9IbQvDY8S/UrmiFswGU8HNjrfV6lfHgqqtM=; b=o+8NItuCCpnRdiauTViD5O08h+zFLlRXewas6PuyMzCO4SknC+ug1gL8Q9awOoom+ePV+Exrsh3OCxON7aZrQ8T5VukXfwUlw33yiZdqWCtAOgcl6TVWQmUCwWVJHXoW+Z1CZxXTkd60SaF7S9nAL01tsQsJZZqtjoHWXOM3eAyP6gzx7P1+5Ha9c5FCj5SVeNab3946+Q1J1eMhEROZ6L6OoipRzHGAY9GlKj7MjbJJPpKFfaeEnHjCs+RXpcqEt1fJjcvvuIrmbZQ5ORi8v0AJRRpOD8yNlRjZ+culnzuNuRxljgPdk9RTqPn7rAAtkuYGZbd96M+UVuY2Doyp/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YQBPR0101MB9295.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:62::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.10; Thu, 20 Aug 2026 16:26:28 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0339.008; Thu, 20 Aug 2026 16:26:28 +0000 Message-ID: Date: Thu, 20 Aug 2026 12:26:26 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: fix crash when pretty printing anonymous struct with base class To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260817145907.142300-1-simon.marchi@efficios.com> <87se48u5i2.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87se48u5i2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0103.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::6) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YQBPR0101MB9295:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a020b20-381e-4358-59e1-08defed7c8f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|23010399003|1800799024|366016|376014|22082099003|18002099003|10067099003|56012099006|4143699003; X-Microsoft-Antispam-Message-Info: 6WbkK7qV5SVseWqk6QhAx8AgBX0Rpi6hyLTETL5aVTRD/34wMweVYgHaCRy20lU0ydmqiLDEkAQMXIXq48NZhH6Z3CeQxhhgH8zPkChJCFXT3iOWN2+CRmnq0D9mW/Lu+z5dIl54XkL+24dFCNXQ9bAgCBbiD2XNefVM/jwBY8aznfSF9ujR5YA15cbEyfseaWIBGNlHEmshIOR/1UrsDqzsXedJgv1HCSt0uUaYX00kSKgaJkQ1q+fSXrU/EiibMQpOulgRB1+5FOc+6dCUQEFoF+n2M4SkJ0HJiw1m51iZra4NjKbnwm981NEZNdgs3WFNnWxMbZaeHfg7fICpoZ0Dv0dxQbrMM1YRLKL6kTnk8HHkCXyopeeuswVjlBwx/rJBFVXGA2101nSALxLCTjPM/babpso2f1fFeP8s7fgNETmT8y2wEkzbSYzO2NTSWoGD2Ko0K6sNzR0oUfZ+U9d8H9YeY2hEczNLnaVKFkNmxvJbgTPKZfjfIFpd7H6fa6MzcQA+aNsyHDtTeZvK9NhMDe/sKbH19kJOx+s+puMZz+efrdCbIumqaO4fbB4IVjHhnVzwTpq+HrLvc4dG3EzxQ9Rcr1WbO6DACnCwJ1IKgTr5+f5QC4o/PZxuek7KOdBmh7W7feS3wihw5X5nPuuPL0tPCNrHpMpf6+REb+M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(23010399003)(1800799024)(366016)(376014)(22082099003)(18002099003)(10067099003)(56012099006)(4143699003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHZ3MmJ2bG5NbGVLYmdscWloSHYyZHEyRnZOb09jODlGeXA2SDBmYTkrc0Vw?= =?utf-8?B?b1l1S1A2RlFyZmVPNDZqUUpTZ0ordnlFNytVaFB0bkxxNGxwSXR5azdlMFZh?= =?utf-8?B?ME4veTVrWjA1UWUrRlcxVWc0dnBGblpQakgyaFZJVXRvRVEyYWFNK2JablhG?= =?utf-8?B?RnM1MzNKNzlGaUNUSitDdHVPU2lvNk1VVkZxMDQzY0xHZm11T09qU2pOWXhz?= =?utf-8?B?aEowemh6UnVaVkFTTzhtbSttRTR5cktodVY4ZjZmdG5Jdkk0S3E1WlVaek1D?= =?utf-8?B?bzh2SVg5cHlheXRNNXdUNW9YMUtZTzg3TFVKYnN0cDhuRG81b1c4alRyTU9Z?= =?utf-8?B?anRxN3VQMjJGaVFNU3FzV3VXdkVGeXUwRk9lcytrdUZPOEZiM3B4c2M2VFcz?= =?utf-8?B?Sm40L3loUDYyY2R6bEp2MWM4RnVKM0d2MGliaCtzYXRDWTA1dGJCQWFnOU9G?= =?utf-8?B?SmE2RDBmbGNNL0ZoSkxVdGpUZVh0TG5xRGRtdnNYZXE4VjJRd0hoZFRZTjVz?= =?utf-8?B?NU9vK1VTRzhGWWtud2pEdkNBQTRGVE1pcnN5QUN3cXMwMTdkZE1PbGM0Q2lU?= =?utf-8?B?MzJlK2d1eVZkTnRRT3RjQ1VjV3ljSm5EWWptZUx3d0NDc1BNSi9nVEdtQVdJ?= =?utf-8?B?eExXWTFhSk8wUEtRQVpldTczaEdvYTlrSExXUXBQODJRRFIvVEZZaFlGUDNU?= =?utf-8?B?Zmo2cHhJTkZQVURwTWx4NEdRZHBFeHNONkphRTRqWWo3R2pOcTRNMjRZa3dz?= =?utf-8?B?SkxXdEFoYkJESjYvRWl3L2orTk90OXVpaXNvdzdHUFkzKzBzZEt0ODczTUgv?= =?utf-8?B?S0F6bWdiZGJnbWF4MU1IcUFVdEdnNEo5aVo4SG1rSUY2VVJ2Z3VmMzBUVHFu?= =?utf-8?B?SVBQekNsK3FSbitlS0NHblRDQnA5U3JSQjk0Z2RtTWdwV3hTZWJDUUNBYmF5?= =?utf-8?B?cW8zMDh2VmMvcDZZYklrZ29NWkduUERhVTFYN2VsTzVYMUFoME1GcjFsQU1y?= =?utf-8?B?L21YWG5NTkdIWHRjb3FOSEVtWGxia0NPMi83R1Vwalo4N29rRWFNRnZ1UXhT?= =?utf-8?B?bHYzRkZZdGlMeHJhU1QwaDUvYXdPWVBZbWIxYmRLL2QvS1laNm5UNXFoaWt1?= =?utf-8?B?cnFzdWpzeUlCVUtlak5tTWtCYmN6QXdYeGx4RlVIWGV3cTNtNTlJMXBaZGM2?= =?utf-8?B?R2NJd0taaDF6aXdXQXB6cForRzJNZ2lWVFoxNUdBemdlWUtDQk5GMEdBMEtr?= =?utf-8?B?SVR1RmZaQWRRVDhYUFI5LzNNaFNtZG0vT2tqMzA2eUUzQkFwa05IS05pa2NF?= =?utf-8?B?NHNtRUFib09rUEV3dDZmMm5zRk5EL3NhMExZNjdxM2ovTjMwTDE0R001TGRn?= =?utf-8?B?L3gzUGJRQXdRZFJ2UzNyOEhLUkg3dkpZblhvbHRmNFYwZmhRMnVLWmhZdHU1?= =?utf-8?B?VW9WdlRNbXIyQTQ4R0djbWRqc2gxR0xuR1BLS0dHVXk4VVJ0TVVVUTlDSXVy?= =?utf-8?B?SHNWUEkrcUJTcmloZGNCcU45SFRhYWlkenlnNTB4cnpOengzTVJqY1lKNWwx?= =?utf-8?B?VERmelAzb0F5SncwNHZJcnhHQ0dIdXkzbVArdGYyOW0yUHowY0Mrdy9NNTIx?= =?utf-8?B?N2xsV0FsWmZqWkZKQ21MbnBIWnExKzM1T2dkSUxEelpjV2loRzlUdHNNc1dC?= =?utf-8?B?RVFkUW45ekhwcnk3V053RWlmY3h2SEMrNExPelVJdXpjc0RabjJJSnphL2E1?= =?utf-8?B?bW1hVEc3QWRFaG9JQ0w4WWZ1cnEvaXpCQkhtNitUaFlPanNrSGs0cHY4akhR?= =?utf-8?B?Z1V3ZENQUDdNc3NjSm1DNXNweWs5N3hTYXN0QTQrVDZ3N0tRSm1kTm1JSnZq?= =?utf-8?B?UldCZnppSHBqTE5KaGZhcFhjaVpZaXhVam5xVlNMZm5XTlN0OGpuRXpjU3Ex?= =?utf-8?B?UHR0TlROb1lxYjNvb0trdkp0UHRRZjRtMk1tYWgvOEVuOFJuUzFtUi9HOTNr?= =?utf-8?B?QVhJSG9yQlAvRjc1Vy9vYW5remRqUGFvUnFVZ3huZGc3VHFoQ2hNRHJ2b2g1?= =?utf-8?B?ZHE0SzBROXNlL2IvTUtvSmJKVE56cGozZ0k3MmxObUpCMHVtNk4wd3hxeG5k?= =?utf-8?B?c05neGhzK2ZFU040eGZ5NURMczBJcjdpYlg4dExOK3FGMmREWWticFJQUDBa?= =?utf-8?B?QnpDcFFhM0d1K1pmenpsem41andWUUhueHUxS2VwZzBrRS93VUtYZlNISUZv?= =?utf-8?B?Y2dVbHpobmxjRlB2cU82ajZOeUtsSkFjaVJkWjVoM1RwL2NrUGFjTGxERG1K?= =?utf-8?B?QnV6bE9GS296V1dQK1FjcjF1WndVZy9KK1Jzd25tL2RDWU52M2FPU20rVVVi?= =?utf-8?Q?nfXtTzFtdBcRN4VkBaoOp1p01y50gbSzYf7rKpU2FmtWY?= X-MS-Exchange-AntiSpam-MessageData-1: NBoOoqO+qA2ecw== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a020b20-381e-4358-59e1-08defed7c8f8 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2026 16:26:27.8660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EuTFKz4JKAlH1ApQJe+fUdmr8HFHSAIlX5iT914KEqXPQ5lIxgh7xFG7jnPf1mO5gjqOeoNnFqyuAOq65ePaRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB9295 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/20/26 12:21 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> As I was reviewing another patch, I was wondering if we allowed > Simon type->name() to be nullptr. The answer is yes, but there are some spots > Simon> that don't check for nullptr, when they should. > > Thanks for looking at this. > > I sometimes wonder if this is something we ought to fix, like reject > nullptr here. But shrug. I think we could initialize it to "" so that it's never nullptr, and we have just one normal way to representing a type with no name. > Simon> - gdb_puts (type->name (), stream); > Simon> + gdb_puts (type->safe_name (), stream); > > It would be nice here if the <...> form were in metadata style. I'll look into it. Simon