Re: [PATCH 2/3] gdb: Set max-value-size before running tests.

Andrew Burgess
2016-01-05T14:14:23Z

* Joel Brobecker <brobecker@adacore.com> [2016-01-01 13:52:54 +0400]:

> > > Setting the max-value-size before running any tests should prevent any
> > > issues where a failing test causes gdb to bring down the testing
> > > machine.
> > >
> > > The maximum size is set to 1G, this is large enough to handle all the
> > > well behaving tests, and should make no difference to the test results.
> > >
> > > There is one test, gdb.mi/mi-vla-fortran.exp that contains undefined
> > > behaviour, one some machines this test is known to trigger the
> >
> > I suggest changing "behavior," to "behavior;".
> > Also "one some" -> "on some".
> >
> > > max-value-size error. However, on those machines the test would have
> > > failed anyway, so this commit does not change the PASS / FAIL nature of
> > > the test. A later commit should modify the mi-vla-fortran.exp test to
> > > expect the failure case.
> > >
> > > gdb/testsuite/ChangeLog:
> > >
> > > * lib/gdb.exp (default_gdb_start): Set max-value-size.
> > > * lib/mi-support.exp (default_mi_gdb_start): Likewise.
> > > * gdb.base/max-value-size.exp: Don't check the initial value.
> >
> > Looks good. This patch is approved to go in after patch #1 is
> > approved.
>
> Actually, I take that back!!!
>
> I just realized that this only makes sense if we left the default to
> unlimited, but as you saw in my previous message, this is not the case.
> So I think we should simply drop the lib/ part of the patch and
> just keep the gdb.base/max-value-size.exp part. We'll the wait and
> see if any test triggers an unexpected failure on some platforms,
> but those would be. But, my guess is that those unexpected failures
> might actually be indicative of a real issue ;-).
>
> Thanks, and sorry for the confusion!

No problem. With the default now being set in patch #1, the *.exp
changes naturally move there too. As a result this patch is now
empty.

I've applied it as obvious ;-)

Thanks,
Andrew