Re: [testsuite patch] testsuite regression: gdb.fortran/vla-value-sub.exp gdb.fortran/vla-value-sub-finish.exp [Re: [PATCH 1/3] gdb: New set/show max-value-size command.]

Andrew Burgess
2016-02-14T00:51:19Z

* Jan Kratochvil <jan.kratochvil@redhat.com> [2016-02-13 22:40:46 +0100]:

> On Wed, 06 Jan 2016 12:40:50 +0100, Andrew Burgess wrote:
> > +static int max_value_size = 65536; /* 64k bytes */
>
> FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array)
> FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was mofified in debugger (passed fixed array)
> FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was filled
> FAIL: gdb.fortran/vla-value-sub-finish.exp: print array2 in foo after it was mofified in debugger
>
> print array2
> value requires 296352 bytes, which is more than max-value-size
> (gdb) FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed fixed array)
>
> OK for check-in?

Not a maintainer, but this looks fine to me.

Apologies for not spotting the breakage, this error triggered so often
in the fortran tests I admit I got a bit lazy and assumed they were
all legitimate.

Thanks for tracking these down,
Andrew

>
> Tested on x86_64-fedora23-linux-gnu.
>
>
> Jan

> gdb/testsuite/ChangeLog
> 2016-02-13 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.fortran/vla-value-sub-finish.exp (set max-value-size 1024*1024):
> New test.
> * gdb.fortran/vla-value-sub.exp: Likewise.
>
> diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> index c47ef2c..fde6c9f 100644
> --- a/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-value-sub-finish.exp
> @@ -32,6 +32,8 @@ if ![runto_main] {
>
> gdb_breakpoint [gdb_get_line_number "array2-almost-filled"]
> gdb_continue_to_breakpoint "array2-almost-filled"
> +# array2 size is 296352 bytes.
> +gdb_test_no_output "set max-value-size 1024*1024"
> gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \
> "print array2 in foo after it was filled"
> gdb_test "print array2(2,1,1)=20" " = 20" \
> diff --git a/gdb/testsuite/gdb.fortran/vla-value-sub.exp b/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> index 361d7a9..179683d 100644
> --- a/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-value-sub.exp
> @@ -42,6 +42,8 @@ gdb_test "print array1(1, 1)" " = 30" \
>
> gdb_breakpoint [gdb_get_line_number "array2-almost-filled"]
> gdb_continue_to_breakpoint "array2-almost-filled (1st)"
> +# array2 size is 296352 bytes.
> +gdb_test_no_output "set max-value-size 1024*1024"
> gdb_test "print array2" " = \\( *\\( *\\( *30, *3, *3,\[()3, .\]*\\)" \
> "print array2 in foo after it was filled (passed fixed array)"
> gdb_test "print array2(2,1,1)=20" " = 20" \