From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aLbUEfsbBWYLMxkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 03:27:55 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HAMgI4Dq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BmV+hO1E; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HAMgI4Dq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BmV+hO1E; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4318B1E0C0; Thu, 28 Mar 2024 03:27:55 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2BB3E1E030 for ; Thu, 28 Mar 2024 03:27:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0A65385DC0F for ; Thu, 28 Mar 2024 07:27:52 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D85B13858D20 for ; Thu, 28 Mar 2024 07:27:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D85B13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D85B13858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711610851; cv=none; b=fp9Zu3XOa3GtStkvZQ2UX7KJvGtrhz4LCjva0sZmFB5Jph4irtN1RwYgKZLT3vH+S8xYM5EKhrQHfIlpRbVbI5KdZ7PqrtaUSF+CRY+IOTA1/hYPQEVxUpL14n52Eo2Jb7djG+VzIthkrQqQ+qXTYHEoOou2j0yX65aCtCzBFtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711610851; c=relaxed/simple; bh=15YBSTuVvWr3dHmqBhWdC+Tr6vraSkjVzJCH4pgqhs4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=QYhHOJmupXSERzi4QDhvIuvuGG/uK8haeGjTpjplctulZNhaZ6YLJ6+7l/qPjHFkxG+wWVWcOs7n8M1+CgdzNVcjVtESYoMys1SHEXLhKaBP3rMg0GsgG21OXvXRIWUjMDS2roMl2qOlbq1ikE6PVQsJse8dsk0mIvczgGGQp+8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA5FA2054E for ; Thu, 28 Mar 2024 07:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711610848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oSYlwbx1nzpgGbs58QpXlZyTLRhGc0RB8ns3WBqG0s=; b=HAMgI4DqHLJ8ORIrky7R1oeL8UOKKtxvoqSdFMZ+x3FAQUSDW7uism6KB3mBu7ZWyZnZTR jWDveJvwjlp6mDmDUcOnKdgelOHb6JhyUT+/WtIYtLVFRNVbUJax8IPeqBq7Ly6O5x2tK+ 6lGf7++UGNssb8EuGmVO1lxbzWTC1sY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711610848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oSYlwbx1nzpgGbs58QpXlZyTLRhGc0RB8ns3WBqG0s=; b=BmV+hO1ElmZYgLjO/UPZueVTeVbuqLWPk+rbnV1j6dPgUNqteFy4VHa94Jq3w3ASaF+z91 QwZz04bSMKjcGGDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711610848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oSYlwbx1nzpgGbs58QpXlZyTLRhGc0RB8ns3WBqG0s=; b=HAMgI4DqHLJ8ORIrky7R1oeL8UOKKtxvoqSdFMZ+x3FAQUSDW7uism6KB3mBu7ZWyZnZTR jWDveJvwjlp6mDmDUcOnKdgelOHb6JhyUT+/WtIYtLVFRNVbUJax8IPeqBq7Ly6O5x2tK+ 6lGf7++UGNssb8EuGmVO1lxbzWTC1sY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711610848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oSYlwbx1nzpgGbs58QpXlZyTLRhGc0RB8ns3WBqG0s=; b=BmV+hO1ElmZYgLjO/UPZueVTeVbuqLWPk+rbnV1j6dPgUNqteFy4VHa94Jq3w3ASaF+z91 QwZz04bSMKjcGGDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id A9BFF13AF7 for ; Thu, 28 Mar 2024 07:27:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id ICxvJuAbBWYTSQAAn2gu4w (envelope-from ) for ; Thu, 28 Mar 2024 07:27:28 +0000 Message-ID: Date: Thu, 28 Mar 2024 08:27:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix test-case gdb.threads/attach-stopped.exp on manjaro linux Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20240314101335.25078-1-tdevries@suse.de> In-Reply-To: <20240314101335.25078-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.50 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.50 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-0.999]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:98:from] X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HAMgI4Dq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BmV+hO1E X-Rspamd-Queue-Id: BA5FA2054E X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/14/24 11:13, Tom de Vries wrote: > When running test-case gdb.threads/attach-stopped.exp on aarch64-linux, using > the manjaro linux distro, I get: > ... > (gdb) thread apply all bt^M > ^M > Thread 2 (Thread 0xffff8d8af120 (LWP 278116) "attach-stopped"):^M > #0 0x0000ffff8d964864 in clock_nanosleep () from /usr/lib/libc.so.6^M > #1 0x0000ffff8d969cac in nanosleep () from /usr/lib/libc.so.6^M > #2 0x0000ffff8d969b68 in sleep () from /usr/lib/libc.so.6^M > #3 0x0000aaaade370828 in func (arg=0x0) at attach-stopped.c:29^M > #4 0x0000ffff8d930aec in ?? () from /usr/lib/libc.so.6^M > #5 0x0000ffff8d99a5dc in ?? () from /usr/lib/libc.so.6^M > ^M > Thread 1 (Thread 0xffff8db62020 (LWP 278111) "attach-stopped"):^M > #0 0x0000ffff8d92d2d8 in ?? () from /usr/lib/libc.so.6^M > #1 0x0000ffff8d9324b8 in ?? () from /usr/lib/libc.so.6^M > #2 0x0000aaaade37086c in main () at attach-stopped.c:45^M > (gdb) FAIL: gdb.threads/attach-stopped.exp: threaded: attach2 to stopped bt > ... > > The problem is that the test-case expects to see start_thread: > ... > gdb_test "thread apply all bt" ".*sleep.*start_thread.*" \ > "$threadtype: attach2 to stopped bt" > ... > but lack of symbols makes that impossible. > > Fix this by allowing " in ?? () from " as well. > > Tested on aarch64-linux. > Pushed. Thanks, - Tom > PR testsuite/31451 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31451 > --- > gdb/testsuite/gdb.threads/attach-stopped.exp | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.threads/attach-stopped.exp b/gdb/testsuite/gdb.threads/attach-stopped.exp > index 4be0e220b17..78e194c992f 100644 > --- a/gdb/testsuite/gdb.threads/attach-stopped.exp > +++ b/gdb/testsuite/gdb.threads/attach-stopped.exp > @@ -54,10 +54,12 @@ proc corefunc { threadtype } { > } > > # ".*sleep.*clone.*" would fail on s390x as bt stops at START_THREAD there. > + set test "$threadtype: attach2 to stopped bt" > if {[string equal $threadtype threaded]} { > - gdb_test "thread apply all bt" ".*sleep.*start_thread.*" "$threadtype: attach2 to stopped bt" > + gdb_test "thread apply all bt" \ > + ".*sleep.*(start_thread| in \\?\\? \\(\\) from ).*" $test > } else { > - gdb_test "bt" ".*sleep.*main.*" "$threadtype: attach2 to stopped bt" > + gdb_test "bt" ".*sleep.*main.*" $test > } > > gdb_exit > > base-commit: 3a4c6f1aa958739705ee69526fdeed7c69d7243c