From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61964 invoked by alias); 4 Oct 2019 21:29:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61956 invoked by uid 89); 4 Oct 2019 21:29:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 21:29:16 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x94LSeNh001693; Fri, 4 Oct 2019 21:29:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=kh6SOSMYwUjD+bzIXToDPyeCPzLDho5NP8LbBICeNbk=; b=d77hxIvhAozAANC9V/KbZanRSdYnlpWyML3tNM9qVZeEGhRe67ykc3o9iwFG89Q7SZoc jzRLeqJyCoPGJ/JkwCtpWE3rSouV+HS4++ZEMvFPatCQRUJDXm0wJh4GzU3wNVIdJ7We 45HnCaDoAd2F2ouj5o3Jl8TKTTNKQLlHHEHyFLvyFrCK8WauUYrFYigqLdinU1zNPxjd dlpwSRKVV206FHBf92uUt28HpJiH/qv1AL0vBuiPczc5GldHaPYLGnHpXpGxvuL2krbi vDwv/hvm36N2Ie3hRrCuCMRGdwd99vR4/pcWimj48/LGgNO0isL4eafOFSP6ZwmYcpMf bA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2v9xxve6td-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Oct 2019 21:29:12 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x94LRjlh167940; Fri, 4 Oct 2019 21:29:11 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2vebbx0ev1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Oct 2019 21:29:11 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x94LTAE0021106; Fri, 4 Oct 2019 21:29:11 GMT Received: from [10.132.97.56] (/10.132.97.56) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 04 Oct 2019 14:27:55 -0700 USER-AGENT: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Message-ID: Date: Fri, 04 Oct 2019 21:29:00 -0000 From: Weimin Pan To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdb: CTF support References: <1570143372-27092-1-git-send-email-weimin.pan@oracle.com> <31e9cadf-29b3-be60-77ce-eb856fe82c38@simark.ca> In-Reply-To: <31e9cadf-29b3-be60-77ce-eb856fe82c38@simark.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-10/txt/msg00158.txt.bz2 On 10/3/2019 6:10 PM, Simon Marchi wrote: > On 2019-10-03 6:56 p.m., Weimin Pan wrote: >> [Changes from v2: >>  - Address Simon Marchi's comments, mainly: >>    * Use gdb::unique_xmalloc_ptr<> to minimize the manual memory management. >>    * Modify create_partial_symtab to handle multiple-CUs correctly. >>    * Improve defining/using ctf_context_t and field_info structs. >>    * Conform to GNU's coding standards. >> >> .... >> This patch has missing features and limitations which we will add and >> address in the future patches. > > Hi Weimin, > > 1. Could you please split the renaming of ctf (the trace format) to tracectf to its > own patch, just before this patch (send them as a patch series)?  It will keep this > patch more focused on its main topic. Hi Siomn, FYI, just posted the patch series. > > 2. When applying the patch, git told me: > > .git/rebase-apply/patch:1079: trailing whitespace. >       { > .git/rebase-apply/patch:1083: trailing whitespace. >       } > .git/rebase-apply/patch:1824: trailing whitespace. > > .git/rebase-apply/patch:1889: trailing whitespace. > > .git/rebase-apply/patch:1894: trailing whitespace. > > Can you try to fix those?  One way of finding the offenders is to do "git show" > and look for trailing spaces by searching for `. $` in less. Fixed. > > 3. I think the binutils patchset has been merged now?  Could you please rebase > on the latest master and force-push your users/weimin/ctf branch? Yes, binutils has been pushed yesterday. Would you please take a look at the patch series and let me know if you have any comments. > >> gdb/ChangeLog >> +2019-10-03  Weimin Pan  >> + >> +    * gdb/ctfread.c: New file. >> +    * gdb/ctfread.h: New file. >> +    * gdb/elfread.c: Include ctfread.h. >> +    (struct elfinfo text_p): New member ctfsect. >> +    (elf_locate_sections): Mark CTF section. >> +    (elf_symfile_read): Call elfctf_build_psymtabs. >> +    * gdb/Makefile.in (LIBCTF): Add. >> +    (CLIBS): Use it. >> +    (CDEPS): Likewise. >> +    (DIST): Add ctfread.c. >> +    * gdb/tracectf.h: Rename, was gdb/ctf.h >> +    * gdb/ctf.c: Replace ctf.h with tracectf.h >> +    * gdb/tracefile.c: Likewise >> +    * gdb/tracepoint.c: Remove unused include ctf.h >> +    * gdb/mi/mi-main.c: Likewise > > Drop all the gdb/ prefixes from this list, as we want all entries to be relative > to the ChangeLog file they appear in. Done. > >> +    * Makefile.def (dependencies): Add all-libctf to all-gdb >> +    * Makefile.in: Add "all-gdb: maybe-all-libctf" > > Changes made to the top-level Makefile.def/Makefile.in will go in the top-level > ChangeLog. > > Simon Thanks, Weimin