From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39148 invoked by alias); 29 Oct 2016 19:57:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39138 invoked by uid 89); 29 Oct 2016 19:57:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=cordian X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 29 Oct 2016 19:57:26 +0000 Received: by simark.ca (Postfix, from userid 33) id CA2FB1E125; Sat, 29 Oct 2016 15:57:24 -0400 (EDT) To: "Cordian A. Daniluk" Subject: Re: [PATCH] Fix PR breakpoints/20739: Badly formatted adress string in error message X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 29 Oct 2016 19:57:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20161029183957.32605-1-th3c0r1uk@gmail.com> References: <20161029183957.32605-1-th3c0r1uk@gmail.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00840.txt.bz2 On 2016-10-29 14:39, Cordian A. Daniluk wrote: > Remove duplicate `0x'-prefix for the hex address printed. `paddress' > already prepends this, so no need to do it manually. > > gdb/ChangeLog: > > * breakpoint.c (check_fast_tracepoint_sals): fix PR > breakpoints/20739 > --- > gdb/breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 25849da..0adebae 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -9628,7 +9628,7 @@ check_fast_tracepoint_sals (struct gdbarch > *gdbarch, > old_chain = make_cleanup (xfree, msg); > > if (!rslt) > - error (_("May not have a fast tracepoint at 0x%s%s"), > + error (_("May not have a fast tracepoint at %s%s"), > paddress (sarch, sal->pc), (msg ? msg : "")); > > do_cleanups (old_chain); That seems like an obvious fix to me, thanks for addressing it. For the ChangeLog entry, you should follow the standard format as described in the following link: https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog That means to put the PR mention above the list of files. The description should tell more or less precisely _what_ has changed (and not _why_ it was changed, that belongs to the commit message, which is already clear in your case). For example: PR breakpoints/20739 * breakpoint.c (check_fast_tracepoint_sals): Don't print duplicate 0x prefix. I don't see your name in MAINTAINERS, do you have write access to the repo? If you plan to contribute patches regularly, it would be a good idea for you to go through the process to get it (you'll need assistance from one of the global maintainers). Otherwise, somebody else with write access can push it for you. Thanks, Simon