Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: tromey@sourceware.org, gdb-patches@sourceware.org,
	"Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
Subject: Re: [review] Allow re-assigning to convenience variables
Date: Thu, 14 Nov 2019 16:44:00 -0000	[thread overview]
Message-ID: <cb5360ca-c3b0-23d4-bd8e-512aff439056@redhat.com> (raw)
In-Reply-To: <gerrit.1573749432000.I5e66a2d243931a5c43c7af4bc9f6717464c2477e@gnutoolchain-gerrit.osci.io>

LGTM.

> +    gdb_test "print \$arr = { 1, 2, 3}" \

> +    gdb_test "print \$arr = { 0, 1, 2, 3}" \

Noticed the spurious space after '{' but not before '}'.

Thanks,
Pedro Alves


  reply	other threads:[~2019-11-14 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 16:37 Tom Tromey (Code Review)
2019-11-14 16:44 ` Pedro Alves [this message]
2019-11-14 16:46 ` [review v2] " Tom Tromey (Code Review)
2019-11-14 19:00 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-14 19:00 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb5360ca-c3b0-23d4-bd8e-512aff439056@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox