[PATCH 0/6] Vertical scrolling and another small bug fix

Andrew Burgess
2020-01-07T11:52:28Z

Here's a series that fixes the vertical scrolling issue. It
incorporates your proposed fix (with a small testsuite change), and
then builds upon it.

This is a different (simpler) approach than I originally suggested.

I'm still not really happy with how the tui keeps track and displays
the current symtab_and_line; I think there's many places that GDB
should do a better job of placing the "current" location in the centre
of the screen, where currently it has a tendency to jam the current
location right at the top.

However, I think leaving the ability to vertically scroll broken isn't
good, and I think this series is a step in the right direction
(maybe?).

Thoughts / comments welcome.

Thanks,
Andrew

--

Andrew Burgess (5):
gdb/testsuite/tui: Always dump_screen when asked
gdb/testsuite/tui: Split enter_tui into two procs
gdb/testsuite/tui: Introduce check_box_contents
gdb/tui: Fix 'layout asm' before the inferior has started
gdb/tui: Link source and assembler scrolling .... again

Tom Tromey (1):
gdb: Fix scrolling in TUI

gdb/ChangeLog | 17 ++++++++
gdb/testsuite/ChangeLog | 30 ++++++++++++++
gdb/testsuite/gdb.tui/basic.exp | 40 +++++++++++++++++++
gdb/testsuite/gdb.tui/tui-layout-asm.exp | 34 ++++++++++++++++
gdb/testsuite/lib/tuiterm.exp | 67 ++++++++++++++++++++++++++------
gdb/tui/tui-source.c | 27 +++++++------
gdb/tui/tui.c | 10 +++--
7 files changed, 199 insertions(+), 26 deletions(-)
create mode 100644 gdb/testsuite/gdb.tui/tui-layout-asm.exp

--
2.14.5