Re: [PATCH 1/6] gdb/testsuite/tui: Always dump_screen when asked

Tom Tromey
2020-01-07T18:54:53Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The Term::dump_screen routine currently dumps the screen using calls
Andrew> to 'verbose', this means it will only dump the screen when the
Andrew> testsuite is running in verbose mode.

Andrew> However, the Term::dump_screen is most often called when a test fails,
Andrew> in this case I think it is useful to have the screen dumped even when
Andrew> we're not in verbose mode.

Andrew> This commit changes the calls to 'verbose' to be 'verbose -log' so we
Andrew> always get the screen dump.

Andrew> gdb/testsuite/ChangeLog:

Andrew> * lib/tuiterm.exp (Term::dump_screen): Always dump the screen when
Andrew> called.

Seems reasonable to me. Thanks.

Tom