From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0M2XCyaIHGUW6SMAWB0awg (envelope-from ) for ; Tue, 03 Oct 2023 17:31:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=u1Mh46Em; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2CB5B1E0D0; Tue, 3 Oct 2023 17:31:18 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C3AE1E0C2 for ; Tue, 3 Oct 2023 17:31:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94B063861837 for ; Tue, 3 Oct 2023 21:31:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 94B063861837 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696368675; bh=azwxZA/UAEjqn4aAqSW1RM3WtXs8KUSXZP9cuExEE0I=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=u1Mh46EmhFDGyforyU3FUT5cCR59rpx2ztJqAJsy0HTgb6WoaEfuk6XxcXiTJp5cu ZHs69/MdJL03XJ+yQPVRmGgt5CXf0bplbEzouFhqVvo8MewCScxMLzFql9/uoY+c4N mUi+sY4FqhMIZaullvM5SNqstUsIIn2ELxdirI1Y= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E8247385C6FF for ; Tue, 3 Oct 2023 21:30:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8247385C6FF Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-xXfHR_C9Pd6rpvPOxkFj2Q-1; Tue, 03 Oct 2023 17:30:07 -0400 X-MC-Unique: xXfHR_C9Pd6rpvPOxkFj2Q-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-9ae12311183so121596166b.2 for ; Tue, 03 Oct 2023 14:30:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696368606; x=1696973406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azwxZA/UAEjqn4aAqSW1RM3WtXs8KUSXZP9cuExEE0I=; b=ocX0aOkAZlxWlNrzfeTt41Td48Wr3GiE7h2H+UrYwPQb/S6zvRMtrS7YOs+tf2s4q7 h/b8RNTE6bY97UjrPlEFOr/cWMJf424F8ojuu4qkqo2zQA6X6l/f5Ec5eRYXEl5stOmP X/lUknQYmE9I2bepoPu+lPntDEYLrnU/jr5uLq3ewuvIsc8VRMEuCiH60ahEEMDkspZX YM//8sL4hr20/Fd7XOsk3aPmyo01iAZIaZnBhieARKwtQ+7wloUBxOHKrnKQfJWQHNpI XECW2ree7RxdYZ7kb1+lTdHGJU1xIZzTA5rWKv62NinjrgrIm8uwb2RrbvEnVuL6iBlN k7SQ== X-Gm-Message-State: AOJu0YyJJdE85OBv6/W489SPuWFWIMgj/xqXSuvewW+6dCRApyXu00Kl D5xpgpaxUAgBcz47UBKdjNqR5wQ0sHcrzIwfaKWocXmflfJQU3gDvW4qntxJnXe8WMe5w6mof4v qzRwu3Y1fsRQ36aQwu7p4o2YK0w1qYbAp6lAFqU2r+kDk+jYtM+TBTp6Hk0jnQOODoOW/3R3DNv kGhxsEbQ== X-Received: by 2002:a17:907:75c6:b0:9a5:d972:af50 with SMTP id jl6-20020a17090775c600b009a5d972af50mr399179ejc.19.1696368606057; Tue, 03 Oct 2023 14:30:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFeADuucE2+gkReM8xX7SfnfJYJq0yQjKP6JuxBkATkcZXyiSkp+pGRRrLdg4SzMO9jWYfgeA== X-Received: by 2002:a17:907:75c6:b0:9a5:d972:af50 with SMTP id jl6-20020a17090775c600b009a5d972af50mr399167ejc.19.1696368605801; Tue, 03 Oct 2023 14:30:05 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id n16-20020a170906165000b009920e9a3a73sm1664386ejd.115.2023.10.03.14.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 14:30:05 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess , Lancelot SIX Subject: [PATCHv5 09/10] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Tue, 3 Oct 2023 22:29:42 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index fcd0dfd9c20..e0464e1f173 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -284,9 +284,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -301,10 +298,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12224,17 +12222,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4