From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37231 invoked by alias); 21 Sep 2017 10:06:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37198 invoked by uid 89); 21 Sep 2017 10:06:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:492, yay! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 10:06:54 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D348A039D; Thu, 21 Sep 2017 10:06:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5D348A039D Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 365725D980; Thu, 21 Sep 2017 10:06:52 +0000 (UTC) Subject: Re: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type To: Tom Tromey , gdb-patches@sourceware.org References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-36-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 21 Sep 2017 10:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170921051023.19023-36-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00613.txt.bz2 On 09/21/2017 06:09 AM, Tom Tromey wrote: > > @@ -591,8 +583,7 @@ maintenance_do_deprecate (char *text, int deprecate) > if (end_ptr != NULL) > { > len = end_ptr - start_ptr; > - start_ptr[len] = '\0'; > - replacement = xstrdup (start_ptr); > + replacement = savestring (start_ptr, len); > } This looks like another "command repeat" bug fix, right? Yay! :-) (Please mention it in the commit log.) Thanks, Pedro Alves