From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115116 invoked by alias); 5 Jul 2018 20:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115054 invoked by uid 89); 5 Jul 2018 20:14:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:workin, sk:work-in, Hx-languages-length:841 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jul 2018 20:14:16 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D097CC036751; Thu, 5 Jul 2018 20:14:14 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ADB35D6B5; Thu, 5 Jul 2018 20:14:14 +0000 (UTC) Subject: Re: [RFA 19/42] Move the using directives to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-20-tom@tromey.com> From: Keith Seitz Message-ID: Date: Thu, 05 Jul 2018 20:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-20-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00128.txt.bz2 Trivial nitpicking time: On 05/22/2018 09:58 PM, Tom Tromey wrote: > diff --git a/gdb/buildsym.c b/gdb/buildsym.c > index 5d3d1f2942..4e3ca5e4b1 100644 > --- a/gdb/buildsym.c > +++ b/gdb/buildsym.c > @@ -205,6 +205,14 @@ struct buildsym_compunit > > /* Stack of subfile names. */ > std::vector m_subfile_stack; > + > + /* "using" directives local to lexical context. */ > + > + struct using_direct *m_local_using_directives = nullptr; > + > + /* global "using" directives. */ > + > + struct using_direct *m_global_using_directives = nullptr; > }; > > /* The work-in-progress of the compunit we are building. Since you're modifying these lines, could you update the comments (e.g., capitalize "Global") and remove the newline between the comment and decl? Keith