From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id auEbNN1H5l9zXwAAWB0awg (envelope-from ) for ; Fri, 25 Dec 2020 15:13:17 -0500 Received: by simark.ca (Postfix, from userid 112) id C36951F0AA; Fri, 25 Dec 2020 15:13:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D53B1E965 for ; Fri, 25 Dec 2020 15:13:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 976DD385800D; Fri, 25 Dec 2020 20:13:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 976DD385800D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608927196; bh=goHDhXVNukpkB8Vil/p1M6Sht2crurAA6Tk0OFMFKlo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=N3NJ7XmCOlrUTrOAK/JHffXgmad1XpEgTyDVAOfALr8On915hoNUPSm8FiyhsFEnS Dybn00Cj2RgPsLW3oUWJ+0hXQk3C8WL/9eqo7k9oNEesqWzn9uTe04nOlmYP/CwhSR FNvSa37IvdxW4h55wZ0CQEejA6AB0GOz/jtchs40= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 18F8E385800D for ; Fri, 25 Dec 2020 20:13:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 18F8E385800D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BPKD7jQ014151 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Dec 2020 15:13:12 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BPKD7jQ014151 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 09BEB1E965; Fri, 25 Dec 2020 15:13:06 -0500 (EST) Subject: Re: [PATCH v3 06/24] Unit tests for gdbserver memory tagging remote packets To: Luis Machado , gdb-patches@sourceware.org References: <20201109170435.15766-1-luis.machado@linaro.org> <20201109170435.15766-7-luis.machado@linaro.org> Message-ID: Date: Fri, 25 Dec 2020 15:13:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201109170435.15766-7-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 25 Dec 2020 20:13:07 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-09 12:04 p.m., Luis Machado via Gdb-patches wrote: > Updates on v2: > > - Update unit tests to cope with additional tag type field in the remote > packets. > > -- > > Add some unit testing to exercise the functions handling the qMemTags and > QMemTags packets as well as feature support. > > gdbserver/ChangeLog: > > YYYY-MM-DD Luis Machado > > * server.cc (test_memory_tagging_functions): New function. > (captured_main): Register test_memory_tagging_functions. > --- > gdbserver/server.cc | 100 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 100 insertions(+) > > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index 7eddd0e01f..6812b624f8 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -3647,6 +3647,103 @@ detach_or_kill_for_exit_cleanup () > } > } > > +#if GDB_SELF_TEST > + > +namespace selftests { > + > +static void > +test_memory_tagging_functions (void) > +{ > + /* Setup testing. */ > + gdb::char_vector packet; > + gdb::byte_vector tags, bv; > + std::string expected; > + packet.resize (32000); > + CORE_ADDR addr; > + size_t len; > + int type; > + > + /* Test parsing a qMemTags request. */ > + > + /* Invalid request, addr len and type unchanged. */ > + addr = 0xff; > + len = 255; > + type = 255; > + strcpy (packet.data (), "qMemTags_wrong:0,0:0"); > + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) != 0); > + SELF_CHECK (addr == 0xff && len == 255 && type == 255); As I said earlier, I would have made parse_fmemtags_request assert that the packet begins with "qMemTags:" (instead of returning an error value), but it's really a nit and I can live with both. Otherwise this patch LGTM. Simon