From: Simon Marchi <simark@simark.ca>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Also recognize __sighndlr on Solaris/x86
Date: Sun, 23 Sep 2018 16:03:00 -0000 [thread overview]
Message-ID: <ca3fb627-961e-d072-196c-55d21e1e4b3b@simark.ca> (raw)
In-Reply-To: <yddzhwdhci3.fsf@CeBiTec.Uni-Bielefeld.DE>
On 2018-09-19 8:56 a.m., Rainer Orth wrote:
> Unlike Solaris/SPARC, the __sighndlr function isn't recognized as part
> of a signal handler, causing a couple of testcases to fail.
>
> The following patch fixes that. A followup patch will move this to
> common code to avoid such unnecessary discrepancies between
> Solaris/SPARC and x86 in the future.
>
> While this fixes a couple of backtraces to now correctly print
>
> #1 <signal handler called>
>
> they often fail later with
>
> #2 0x0ff3ffffff00857f in ?? ()
> Backtrace stopped: Cannot access memory at address 0xff3000002e0886f
>
> which needs further investigation.
>
> Tested on amd64-pc-solaris2.11 (running the tests with both -m64 and
> -m32). Ok for master?
>
> Rainer
>
I noticed this had not been replied to, this LGTM. I don't know much about
Solaris, but I trust that you know what you are talking about :) and this
looks pretty straightforward.
Simon
next prev parent reply other threads:[~2018-09-23 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:56 Rainer Orth
2018-09-23 16:03 ` Simon Marchi [this message]
2018-09-23 18:12 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca3fb627-961e-d072-196c-55d21e1e4b3b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox