From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57475 invoked by alias); 6 Oct 2016 09:52:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57441 invoked by uid 89); 6 Oct 2016 09:52:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 09:52:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39541C04B930; Thu, 6 Oct 2016 09:52:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u969qDEd003015; Thu, 6 Oct 2016 05:52:13 -0400 Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER. To: Peter Bergner , Alan Modra References: <20160930161908.6A43511C24D@oc8523832656.ibm.com> <20161003222527.GO4877@bubble.grove.modra.org> <5a66aca9-dfe9-7c44-21f9-27774a07d143@vnet.ibm.com> Cc: Ulrich Weigand , gdb-patches@sourceware.org, binutils From: Pedro Alves Message-ID: Date: Thu, 06 Oct 2016 09:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <5a66aca9-dfe9-7c44-21f9-27774a07d143@vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00111.txt.bz2 How do you envision this command working if you consider --enable-targets=all? How would we make it work with other architectures? Consider combined debuggers. The fact that the default is explicitly "power9" seems will make generalizing the command awkward? If we made the default be "", and then had a per-arch default, maybe it'd work? But, I suspect that if need to explicitly set one disassembler cpu when debugging a frame of $arch1, and explicitly set another disassembler cpu when debugging a frame of $arch2, you'll end up with lots of juggling. And that juggling is only possible if you only consider explicit disassembling. Things like "set disassemble-next-line" makes that impossible, since it's gdb that decides when to disassemble. Maybe we should instead make the command be "set powerpc disassembler-cpu", or generally, "set $arch disassembler-cpu". We have "set arm disassembler" already. But if we could have a single generic command, that'd be of course better. It's worth it to think about how it'd work at the user-interface level, even if we don't make any other arch use it right away. Thanks, Pedro Alves