From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1235 invoked by alias); 26 Sep 2017 12:19:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 541 invoked by uid 89); 26 Sep 2017 12:19:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=boring, one's, offer X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 12:19:48 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C7327F772; Tue, 26 Sep 2017 12:19:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3C7327F772 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C3A8614DC; Tue, 26 Sep 2017 12:19:46 +0000 (UTC) Subject: Re: [RFA 00/67] Simple add_cmd constification To: Tom Tromey , gdb-patches@sourceware.org References: <20170921051023.19023-1-tom@tromey.com> <8876cd95-2a88-8d57-4240-5e0e17e01acf@redhat.com> From: Pedro Alves Message-ID: Date: Tue, 26 Sep 2017 12:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8876cd95-2a88-8d57-4240-5e0e17e01acf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00794.txt.bz2 On 09/21/2017 11:26 AM, Pedro Alves wrote: > On 09/21/2017 06:09 AM, Tom Tromey wrote: >> First, left me offer my apologies for the length of this series. It >> was somewhat simpler to break it into many tiny pieces, because >> sometimes when const-ifying it is easy to get in over one's head. On >> the plus side, nearly all of the patches are trivial and so review >> should not be too difficult -- just boring. >> >> This starts by adding const-correct overloads of add_cmd and a few >> related functions. Then, it converts many functions to use the >> const-correct form. The idea is to gradually convert all commands >> (and set/show, etc) to const-correctness, then remove the non-const >> overloads. >> >> Regression tested on the buildbot. > > I've read the whole series and sent a few comments, but it > all looks generally fine to me. Those patches that I haven't > commented on looked OK as-is to me. > > Thanks for doing all this. I think you're pretty much good to go. Let me know if you're waiting for something that I missed. Thanks, Pedro Alves