From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FcYpJWZZfGiKTSQAWB0awg (envelope-from ) for ; Sat, 19 Jul 2025 22:50:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTAo81ZR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+v5eUC/b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTAo81ZR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+v5eUC/b; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 485E01E11C; Sat, 19 Jul 2025 22:50:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56E151E0C2 for ; Sat, 19 Jul 2025 22:50:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F36A385C6E0 for ; Sun, 20 Jul 2025 02:50:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F36A385C6E0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTAo81ZR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+v5eUC/b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTAo81ZR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+v5eUC/b Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D020E3858C54 for ; Sun, 20 Jul 2025 02:48:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D020E3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D020E3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752979698; cv=none; b=k11xYRcjgehnFt8tgUsz+WPBTTtNkpZJsVL43BrFH6z3nMg4HEFLdW6x0699HoYqX4QqXoUEEmyPw7vVwLfCIgI+xNOBMZdQcKpfDnwtTQ4az3tIILlthl7d5XXjaHDtvZeVH8oOrcA1f/WlJerPNqTkjUTgo5faYZpqYuClH3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752979698; c=relaxed/simple; bh=k5Ba7jwCquUGT/tfla2dSqsMI5d4hTIlDhtYOZEyF20=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=V+CBAgPSDcdEZ4zWz3A9n0a1Z4cmxogFwurcFe3ibUR5DGZW6A4SDqPOYO+Nvmmgq9QfJ/G8o3NQRPFcigMgXi9G1+dEWYX+TiGO7/oBd/5i2VLDFwpQ62pY7/3H5DKFNIFbIAcopXld0p/zIP3VAJtwyt51xiMfAp4/308m9N8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D020E3858C54 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB5DF1F38A; Sun, 20 Jul 2025 02:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752979696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQXll4JOGMjGDtC6LAjDBQssKliT4OjwRkrpK0/pMOQ=; b=oTAo81ZRzB4ffup8v3jPhvdpNUFgIMcuVmk2NMNZlP6RzpqBs/VC7fdsJaZAYnDrLEKAWv wcg7oBTC0Z5x9xP/Y7tb4AcjgOIs/C58oAI5YWYN6VHWTn0Bb3+tnAeODPJxI6yu5QAzYv FqYBTry7rp87sz+KYtTyUgOTkO41Fyk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752979696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQXll4JOGMjGDtC6LAjDBQssKliT4OjwRkrpK0/pMOQ=; b=+v5eUC/bQ2B3QNXjNctvh1hqBNoEkdCacEXImmGqKQXSJx2UCMWqXIe2gkxges8HYXVib0 2cutvRCFJ0atYTCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752979696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQXll4JOGMjGDtC6LAjDBQssKliT4OjwRkrpK0/pMOQ=; b=oTAo81ZRzB4ffup8v3jPhvdpNUFgIMcuVmk2NMNZlP6RzpqBs/VC7fdsJaZAYnDrLEKAWv wcg7oBTC0Z5x9xP/Y7tb4AcjgOIs/C58oAI5YWYN6VHWTn0Bb3+tnAeODPJxI6yu5QAzYv FqYBTry7rp87sz+KYtTyUgOTkO41Fyk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752979696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQXll4JOGMjGDtC6LAjDBQssKliT4OjwRkrpK0/pMOQ=; b=+v5eUC/bQ2B3QNXjNctvh1hqBNoEkdCacEXImmGqKQXSJx2UCMWqXIe2gkxges8HYXVib0 2cutvRCFJ0atYTCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0D4013A1E; Sun, 20 Jul 2025 02:48:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id v8Q3JfBYfGgqTwAAD6G6ig (envelope-from ); Sun, 20 Jul 2025 02:48:16 +0000 Message-ID: Date: Sun, 20 Jul 2025 04:48:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] [gdb/reverse] Fix failing test: i386-avx-reverse To: Shiven Kashyap , gdb-patches@sourceware.org Cc: guinevere@redhat.com References: <20250719200052.28404-1-shivenkashyap24@gmail.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20250719200052.28404-1-shivenkashyap24@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/19/25 22:00, Shiven Kashyap wrote: > Running the standalone test `gdb.reverse` leads to the following failure: > ''' > FAIL: gdb.reverse/i386-avx-reverse.exp: verify ymm15 before vbroadcastsd > ''' > Hi, thanks for the patch. I first couldn't reproduce this, but then I managed using target board unix/-fPIE/-pie. > This happens because the AVX broadcast instructions expect an actual value, but instead > it cast memory address of a buffer like so (see 'vpbroadcast_test' in 'i386-avx-reverse.c'): > ''' > asm volatile ("vbroadcastss %0, %%xmm15": : "m" (dyn_buf0)); > ''' > This is a bit misleading, because vbroadcastss can handle memory operands, not just "actual values". After your fix (which looks correct to me), the generated instruction still accesses a memory address: ... 400abd: 48 8b 05 04 26 00 00 mov 0x2604(%rip),%rax # 4030c8 400ac4: c4 62 79 18 38 vbroadcastss (%rax),%xmm15 ... but this time, the correct one. Thanks, - Tom > which lead to the test failing for the next instruction (`vbroadcastsd`), which depended on the correct value being broadcast to the register. > Also, updated the corresponding expected output (gdb.reverse/i386-avx-reverse.exp) to match. > > Tested on x86-64 Linux. > > Signed-off-by: Shiven Kashyap > --- > gdb/testsuite/gdb.reverse/i386-avx-reverse.c | 4 ++-- > gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c > index a3d64272f24..bf6cb77f313 100644 > --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c > +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c > @@ -299,10 +299,10 @@ vpbroadcast_test () > asm volatile ("vbroadcastss %xmm1, %xmm0"); > asm volatile ("vbroadcastss %xmm1, %ymm15"); > asm volatile ("vbroadcastss %0, %%ymm0" : : "m" (global_buf0)); > - asm volatile ("vbroadcastss %0, %%xmm15": : "m" (dyn_buf0)); > + asm volatile ("vbroadcastss %0, %%xmm15": : "m" (*dyn_buf0)); > asm volatile ("vbroadcastsd %xmm1, %ymm0"); > asm volatile ("vbroadcastsd %0, %%ymm15": : "m" (global_buf0)); > - asm volatile ("vbroadcastf128 %0, %%ymm0" : : "m" (dyn_buf0)); > + asm volatile ("vbroadcastf128 %0, %%ymm0" : : "m" (*dyn_buf0)); > > /* We have a return statement to deal with > epilogue in different compilers. */ > diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp > index 7e75542720c..fb04260766e 100644 > --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp > @@ -395,7 +395,7 @@ if {[record_full_function "vpbroadcast"] == true} { > test_one_register "vbroadcastf128" "ymm0" \ > "0x17161514131211101716151413121110, 0x17161514131211101716151413121110" > test_one_register "vbroadcastsd" "ymm15" \ > - "0x404060004040600040406000404060, 0x0" > + "0x23222120232221202322212023222120, 0x0" > test_one_register "vbroadcastsd" "ymm0" \ > "0x13121110131211101312111013121110, 0x13121110131211101312111013121110" >