From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C5CA43861893 for ; Thu, 13 Aug 2020 12:24:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C5CA43861893 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16466AC61; Thu, 13 Aug 2020 12:25:14 +0000 (UTC) Subject: Re: [PATCH] Update gnulib to current trunk To: Pedro Alves , Christian Biesinger Cc: gdb-patches References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> <791b00ea-60f3-3e3f-8d67-dd017b46ad57@palves.net> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Thu, 13 Aug 2020 14:24:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <791b00ea-60f3-3e3f-8d67-dd017b46ad57@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 12:24:54 -0000 On 7/16/20 4:56 PM, Pedro Alves wrote: > On 7/6/20 7:19 PM, Christian Biesinger wrote: >> Fair enough. This is the module diff: >> >> --- /tmp/old 2020-07-06 13:04:17.837482577 -0500 >> +++ /tmp/new 2020-07-06 13:02:48.636984706 -0500 >> @@ -1,9 +1,12 @@ >> +Module list with included dependencies (indented): >> absolute-header >> alloca >> alloca-opt >> arpa_inet >> assure >> at-internal >> + attribute >> + btowc > > I wonder whether "btowc" potentially conflicts with the logic > in gdb/gdb_wchar.h . We should keep an eye out for that. > > >> builtin-expect >> c99 >> canonicalize-lgpl >> @@ -13,12 +16,12 @@ >> close >> closedir >> count-one-bits >> + ctype >> d-ino >> d-type >> dirent >> dirfd >> dirname-lgpl >> - dosname >> double-slash-root >> dup >> dup2 >> @@ -52,8 +55,8 @@ >> getdtablesize >> getlogin_r >> getprogname >> + getrandom >> gettext-h >> - gettimeofday >> glob >> glob-h >> hard-locale >> @@ -62,6 +65,7 @@ >> intprops >> inttypes >> inttypes-incomplete >> + isblank >> isnand-nolibm >> isnanl-nolibm >> largefile >> @@ -69,7 +73,6 @@ >> limits-h >> localcharset >> locale >> - localtime-buffer >> lock >> lstat >> malloc-posix >> @@ -78,11 +81,13 @@ >> mbrtowc >> mbsinit >> mbsrtowcs >> + mbtowc >> memchr >> memmem >> memmem-simple >> mempcpy >> memrchr >> + minmax >> mkdir >> mkdtemp >> mkostemp >> @@ -132,13 +137,14 @@ >> strerror-override >> strerror_r-posix >> string >> + strnlen >> strnlen1 >> strstr >> strstr-simple >> strtok_r >> + sys_random >> sys_socket >> sys_stat >> - sys_time >> sys_types >> sys_uio >> tempname >> @@ -156,5 +162,7 @@ >> windows-once >> windows-recmutex >> windows-rwlock >> + wmemchr >> + wmempcpy >> xalloc-oversized >> >> It seems what is getting removed is: >> - dosname (deprecated module and we don't use dosname.h) >> - gettimeofday (it looks like we use this in remote-fileio.c) >> - localtime-buffer (looks like basically an implementation detail) >> - sys_time (looks like GDB specifically did *not* want this per >> comments in gdbsupport/gdb_sys_time.h) >> >> So: >> - For gettimeofday, the fixes in >> https://www.gnu.org/software/gnulib/manual/html_node/gettimeofday.html#gettimeofday >> don't look that important for gdb, but we could include the module. >> Let me know if you want me to. > > I guess it doesn't hurt to explicitly include it. Might as well do it, > since we use the function and have been using the module thus far. > >> >> - For sys_time, we could perhaps replace the #undef in gdb_sys_time.h >> with an #error. Let me know. > > I suspect this gnulib commit is what caused gettimeofday and sys_time to > drop for us: > > commit 78f55d5374d6ff9b8460c48a42e924bf69775cd7 > Author: Paul Eggert > AuthorDate: Sun May 31 20:15:25 2020 -0700 > > tempname: merge from glibc and coreutils > ... > * modules/tempname (Depends-on): Remove gettimeofday, sys_time. > Add getentropy, libc-config. > > As we can see from your diff: > >> sys_stat >> - sys_time >> sys_types >> sys_uio >> tempname > > tempname is a dependency of sys_stat. > > Another option would be to just get rid of gdb_sys_time.h, > i.e., revert all or most of: > > commit 438e1e427e8393de73d22617abe4d8eba0270e72 > Author: Pedro Alves > AuthorDate: Mon Aug 24 18:50:55 2015 +0100 > > Prepare for gnulib update > > But I'd be fine with just leaving this alone for now, in case > gnulib brings back the dependency. It's also the easiest thing to > do (i.e., do nothing). > Hi, it's been four weeks since the last update here, and this is scheduled for the 10.1 release, so ... ping. Any news on this? Thanks, - Tom