From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1h0XB5gJfmoSqCMAWB0awg (envelope-from ) for ; Thu, 13 Aug 2026 14:14:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BCDCfG0S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0AE311E09B; Thu, 13 Aug 2026 14:14:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFECD1E09B for ; Thu, 13 Aug 2026 14:14:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 749114BA9005 for ; Thu, 13 Aug 2026 18:14:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 749114BA9005 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BCDCfG0S Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 6D2274BA23FB for ; Thu, 13 Aug 2026 18:14:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D2274BA23FB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D2274BA23FB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786644858; cv=none; b=YMwORuksJIWaLYbV3q/t44c9WOAsaFP9s+iMhnt67/JN2mFepF4Pj6EsukRA7PrTWRObFVbauh1IKdW7nHbnhv94/XZib0ishYDQ88I5/1Kl6bCU6haqbtDHumAMVfTsOzRo61KlK+3jptTTMA8c7eBtz9Ws2eozn1noHyzwVH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786644858; c=relaxed/simple; bh=hEtOtZQ3+8B/Ye5RttZyYH6QRsaOgOpzZ/JoLyB70Lg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rFkmXaqsVOT0WSOfScm2BTyoax0tHKuVsqMwe0IQ4MLVgryF7iD6Y/ye17IxSyWDhMAZge0xZ/VcFcHhkNPTfCR+uIg6yQL9IMeRLlCzb7Mr9bXGqn5FEbRmVSiGAlBHkSl3MfnshD9cNahhNmqzr743koy52gdGzExj8FqVHKs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BCDCfG0S DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D2274BA23FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786644858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUo2/iMj9cNBIJBD6fZCT4CzuWHT3Hq6ER8IvmG3N30=; b=BCDCfG0SPCHDwc0HbhGgHt/nMdaZDpczh8cO5Ky448GtpEb3WpsuXwvnI2GhQh/kKyLkIk ZdIeIhHy5/KSbUXhiYW830XBiNhXN4YEcs1BZNFKEnR8S8lnYzhpXa2RzU0VKC86wY+QJO 0xh+kX/zjt8WeyjIMvkM+IwPsFhOXvM= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-xFBP6Ug7Oimho3q6uelYTQ-1; Thu, 13 Aug 2026 14:14:15 -0400 X-MC-Unique: xFBP6Ug7Oimho3q6uelYTQ-1 X-Mimecast-MFC-AGG-ID: xFBP6Ug7Oimho3q6uelYTQ_1786644855 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-90410c668adso1245196d6.1 for ; Thu, 13 Aug 2026 11:14:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786644855; x=1787249655; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OUo2/iMj9cNBIJBD6fZCT4CzuWHT3Hq6ER8IvmG3N30=; b=LI6Nvx5ZT7l+DPyZNNp8byVUPcxPetGcTSg2oCRbkxtS5h/M9Xtf9WeReZigvTfUIt AEFrn4fGj/u+JEaOfH1brlR3QPyQEC2mRjKilE8lLlijqpT+pfpmsRlY+R8KjJYK/X9a e0Mk1kgtjraMGbVP9xEdOQtXe4DoY3+QSZ63HnmEEgm3BY1RwcThWCsb2tXdETK1bEXw zEd1tOq0BiGJSOQTaklmqGVEUQujUAIP9P97tHH2yOlUYUTd0kmSWbuQbfzKig0UZoTm uKorO9CuWVP6cqRf7515AHNva0ww9Bdx+Lw4tdIvcxLv088PWQE4f2jpFXy98SXq5bNU zDcQ== X-Forwarded-Encrypted: i=1; AHgh+Roa4NfXBRqoh+5u1kjmVjUY1yLNCW3t17tP84HbUA2PJvvJ2OMIA+4H5e7dZ0YhS5sBpAE0GrDEH6Y6OQ==@sourceware.org X-Gm-Message-State: AOJu0YzNsW5v+UEJf6pvlFYRsqVZsXQA6UZPeRvlXb+IZSdCuGu6FY6M +tmXPjY2ZEE26uBwtQmvFOJBwtr/nihGzWoqgrxZ7zOSsuncsdGppOmyZLxJ3RJQDSNn/C9QptO 7Dpz/+dd9NRoBNoyb/ZeohIlgnNDijTQW4Iy0Rmy3wIgBMbpXi1vVwBH7VxAqiTc= X-Gm-Gg: AR+sD12bntGa+c+ogEOnEJJQrANgTHXBmc6bTftfn+zs784esHMClTXQDk/DF87XVon lHy0FKx+VVy3JhVDM8CbqMek3fRxxScRCajDPISNw0q5JMtfAxHSQIhniVojXHP2xE0qBzAQXSZ 07lBmDxlcGab/XpWANdAO7STwEozDOJB5bTRbpthjjarQQB5rZ3OQNvBBDbqQqG6P3sp6P7Ru89 QFMX6yPS3T3tGm+BlNN6+Fw4FXTc1Mq+54RvDL8l25gAmQ1o1ffbPz3DWCKdyLpsox6y0wrHRPQ or2+ohqgi/g8coztFaw/CpOAEQQhbkzMm6VKinzXy2FHPyU8lGzeN2VZSqCVVnzQYPvhYdVXhu1 PYHiAYA== X-Received: by 2002:a05:6214:2481:b0:8ef:b23a:d741 with SMTP id 6a1803df08f44-90a80c0ac60mr85297916d6.28.1786644854451; Thu, 13 Aug 2026 11:14:14 -0700 (PDT) X-Received: by 2002:a05:6214:2481:b0:8ef:b23a:d741 with SMTP id 6a1803df08f44-90a80c0ac60mr85296936d6.28.1786644853931; Thu, 13 Aug 2026 11:14:13 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90a81ab8115sm20672326d6.43.2026.08.13.11.14.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2026 11:14:13 -0700 (PDT) Message-ID: Date: Thu, 13 Aug 2026 11:14:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] gdb, gdbserver: Add Intel APX register support To: Christina Joos , gdb-patches@sourceware.org References: <20260725105335.2664219-1-christina.joos@intel.com> <20260725105335.2664219-2-christina.joos@intel.com> From: Keith Seitz In-Reply-To: <20260725105335.2664219-2-christina.joos@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hA9fPUwCvfjlQ97u494O7g_hfTl0g9Qap8eUMI74r9A_1786644855 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 7/25/26 3:53 AM, Christina Joos wrote: > From: "H.J. Lu" > > Intel Advanced Performance Extensions (APX) doubles the number of > general-purpose registers (GPRs) from 16 to 32 (r16-r31). Thank you for pursuing this. I'm not going to claim that I completely understand the nuiance of modern x86_64 features, but generally, the code seems okay to me. > Those new 64-bit Extended GPRs (EGPRs) do not change the size of the > XSAVE area, as they take up the space left behind by the deprecated > MPX registers. > > In contrast to the legacy GPRS, EGPRs are not enabled by default in 64-bit > mode but are xcr0 enabled based on APX_F Intel APX state. Define > X86_XSTATE_APX_F to support this new configuration. > > Add gdb and gdbserver registers support for those new 64-bit EGPRs. > Also add byte, word and dword pseudo register support. I appreciate the simplified approach in this revision, removing the previously proposed maint commands. Generating core files is much better/safe approach. One trivial nit (no need to repost): I previously asked whether apx_offset should be set independently of PKRU/AVX512 in i387_guess_xsave_layout()[1]. You explained that APX is only expected with PKRU or AVX512 on known Intel CPUs addresses[2]. A brief comment documenting that assumption would be helpful for future readers. 'Cause, as expected, I forgot all about that discussion already! :-p Reviewed-By: Keith Seitz Keith [1] https://sourceware.org/pipermail/gdb-patches/2026-June/228135.html [2] https://sourceware.org/pipermail/gdb-patches/2026-July/228491.html