From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51367 invoked by alias); 5 Nov 2018 04:16:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51274 invoked by uid 89); 5 Nov 2018 04:16:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=trustworthy, caution X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Nov 2018 04:16:23 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C62691E0A9; Sun, 4 Nov 2018 23:16:21 -0500 (EST) Subject: Re: [PATCH 2/2] Check for line notes on GCC as well as Clang To: Alan Hayward , "gdb-patches@sourceware.org" Cc: nd References: <20181024090427.22721-1-alan.hayward@arm.com> <20181024090427.22721-2-alan.hayward@arm.com> From: Simon Marchi Message-ID: Date: Mon, 05 Nov 2018 04:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181024090427.22721-2-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00042.txt.bz2 Hi Alan, Is a "line note" a concept I am not familiar with, or is it just an entry in the DWARF line number program? On 2018-10-24 5:04 a.m., Alan Hayward wrote: > i386 and amd64 only skip the prologue using line notes if the compiler is > Clang. Also allow this for GCC. Without understanding the problem at hand: since we were only using this info with clang, I assume that there was a point where it wasn't trustworthy with gcc? If so, since when is it trustworthy with gcc, long enough? > With this change we can revert ovldbreak.exp back to only allowing line 49 > as the breakpoint for main. > > Fixes over 50 tests on Ubuntu x86_64. > > Note: Many other targets do NOT have any Clang/GNU check - they allow any > valid result from skip_prologue_using_sal. Maybe that is the better fix > here. However, I was erring on the side of caution. When running the test locally before this series, everything passes. With this series applied, I get: $ make check TESTS="gdb.cp/ovldbreak.exp" ... Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.cp/ovldbreak.exp ... ERROR: can't read "might_kfail": no such variable ... I assume that this particular error is due to a typo, so let's say I fix the faulty line (s/might_kfail/might_fail/), then I get: FAIL: gdb.cp/ovldbreak.exp: continue to bp overloaded : int FAIL: gdb.cp/ovldbreak.exp: continue to bp overloaded : unsigned_int FAIL: gdb.cp/ovldbreak.exp: continue to bp overloaded : long_int FAIL: gdb.cp/ovldbreak.exp: continue to bp overloaded : unsigned_long_int FAIL: gdb.cp/ovldbreak.exp: continue to bp overloaded : float This is with the current gcc on Arch Linux: gcc (GCC) 8.2.1 20180831 Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Again, I don't really have time to dig into it. Simon