From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id adK2MSGwdWoFZRAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 06:14:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YCDAVcb8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=44fQX1nB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aASVqVmI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2ci+q36J; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C7E621E166; Fri, 07 Aug 2026 06:14:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 39C6E1E033 for ; Fri, 07 Aug 2026 06:14:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6948F4BB24F9 for ; Fri, 7 Aug 2026 10:14:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6948F4BB24F9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YCDAVcb8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=44fQX1nB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aASVqVmI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2ci+q36J Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 9F96C4BA9014 for ; Fri, 7 Aug 2026 10:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F96C4BA9014 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F96C4BA9014 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786097672; cv=none; b=CXy5ef3Ccr28ykNba8kBqZSBvVFUwpYR2MpZkwe8ZCu/hAdq6/05Ki+zGLxtRjL7rytbOxtqU5Km1OID1jxuHFfkp811ySV3nNZwzGyflPokO6SBD1Ah0gIPKGaZzOQ0w7Nl49vr66WEHX6RJFuS7JIEDFJXkd9dkEgMoVg91MY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786097672; c=relaxed/simple; bh=2PXOxgR3cizXitovTM4Iq5mU7jZQq3MxqnPE38MyT9k=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=tatNn+uts5INYOLRrk+jjVere53GCp/vyPDi297iwn7WQqnIgdzvu2tl58bpALPtPN1bQLFzASn5gzVNh144OxTyFInU6fSRDKaA3uzXJ7gxdcfbw92kTdjXHMr1cg8eZDQw6cQItM6c+AcpaqU+FQ8ih9XbiSxvNuMGcHcIMmI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YCDAVcb8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=44fQX1nB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aASVqVmI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2ci+q36J DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F96C4BA9014 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7543180560; Fri, 7 Aug 2026 10:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786097667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXeBdbvl9+D6i8cGIH+kagIlzXmdvpByYEm3hszCpE0=; b=YCDAVcb8VzoFS6c9zzkkkjyJXS+A5Z/1xL8dPM3YCJPMY4vuKFqHvhLobWF0CrGGa/MqUA GuT9BPKgldFBYeWgfFlt2DEs6qy+C0TDDtWusdLZ2i9/+vyvgVXe76KakKCUKaNCw9CfzP jD/A6Titmu9dpP8HhFcfBfanoaccUEw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786097667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXeBdbvl9+D6i8cGIH+kagIlzXmdvpByYEm3hszCpE0=; b=44fQX1nBQtmbpW+Ol9KLM3OcneVDYaPHeCH9eB52Wlb/kLXyhszqA5im8qX82g1MPDypcU kxUTMBYYr+FGhPDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aASVqVmI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2ci+q36J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786097663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXeBdbvl9+D6i8cGIH+kagIlzXmdvpByYEm3hszCpE0=; b=aASVqVmIRzYRtk4/AuwJ6EV7FR6jL92nwIo/YHHoi+/WcficDxuPnijJh1Qxqz1FMa7vgf aRVcD7se9WW+WvLF5l4P45aV/QCdWxjHWjOKnlOafmjV9yDqJwbB3fmfY7CHOn1gl6h9q8 zD6/GIyJbAHCBCJzoTqLmptt9atnG8s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786097663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXeBdbvl9+D6i8cGIH+kagIlzXmdvpByYEm3hszCpE0=; b=2ci+q36JEdz8tQv4hgstlYRJa9rr7PC5pP0+keDQDegMkLtndjirWaJVEUu/SbG/bcWpPJ Gaq6iTFU9IhJdzBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FBF1779B6; Fri, 7 Aug 2026 10:14:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id u5UNFv+vdWqpNgAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 10:14:23 +0000 Message-ID: Date: Fri, 7 Aug 2026 12:14:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: share some thread proceed related code between CLI and MI To: Andrew Burgess , gdb-patches@sourceware.org References: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 7543180560 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/6/26 10:54 PM, Andrew Burgess wrote: > + if (inf == nullptr) > + proceed_all_threads (); > + else > + { > + for (thread_info &thread : inf->threads ()) > + proceed_one_thread (thread); > } FWIW, also I wonder if it makes sense to fold this logic into proceed_all_threads: ... diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 23e93587874..d2301ddf093 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -743,10 +743,18 @@ proceed_one_thread (thread_info &thread) /* See inferior.h. */ void -proceed_all_threads () +proceed_all_threads (inferior *inf) { gdb_assert (non_stop); + if (inf != nullptr) + { + for (thread_info &thread : inf->threads ()) + proceed_one_thread (thread); + + return; + } + for (thread_info &thread : all_threads ()) { /* We go through all threads individually instead of compressing diff --git a/gdb/inferior.h b/gdb/inferior.h index 8255654d9b8..2067f60ab7d 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -230,7 +230,7 @@ extern void continue_1 (bool all_threads_p); /* For use only when non_stop is true. Proceed all threads in every inferior. */ -extern void proceed_all_threads (); +extern void proceed_all_threads (inferior *inf = nullptr); /* For use only when non_stop is true. If THREAD is stopped, and is in an inferior that has_execution then switch to THREAD, clear its proceed diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index e110b029e1e..1eb087b85db 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -259,13 +259,7 @@ exec_continue (const char *const *argv, int argc) if (!current_context->all) inf = find_inferior_id (current_context->thread_group); - if (inf == nullptr) - proceed_all_threads (); - else - { - for (thread_info &thread : inf->threads ()) - proceed_one_thread (thread); - } + proceed_all_threads (inf); disable_commit_resumed.reset_and_commit (); } ... Thanks, - Tom