From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127353 invoked by alias); 7 Apr 2017 14:34:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127331 invoked by uid 89); 7 Apr 2017 14:34:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Apr 2017 14:34:00 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by (Symantec Mail Security) with SMTP id 13.69.13281.653A7E85; Fri, 7 Apr 2017 16:33:59 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.339.0; Fri, 7 Apr 2017 16:33:57 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from [142.133.50.178] (192.75.88.130) by VI1PR07MB1726.eurprd07.prod.outlook.com (10.166.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.5; Fri, 7 Apr 2017 14:33:55 +0000 Subject: Re: [PATCH v2] Class-ify ptid_t To: Pedro Alves , Philipp Rudo References: <20170406190328.21103-1-simon.marchi@ericsson.com> <20170407112528.3f03fd37@ThinkPad> <5adec1b9-2faf-d8af-0116-c237ee591738@redhat.com> CC: From: Simon Marchi Message-ID: Date: Fri, 07 Apr 2017 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5adec1b9-2faf-d8af-0116-c237ee591738@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN1PR19CA0021.namprd19.prod.outlook.com (10.163.220.31) To VI1PR07MB1726.eurprd07.prod.outlook.com (10.166.143.22) X-MS-Office365-Filtering-Correlation-Id: 84b006f7-b976-4e8d-7160-08d47dc31f5e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:VI1PR07MB1726; X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB1726;3:opRcGvksL8xjBehfniJZshXfKdVEhbuacad6E0UYN6H8vCaL6pXdjaseYvlfZhz0AJGFSBTCPdxkEADkkzKuhdtIWrkqKqkMRLai8k4jzZSoeW2NfW4LejcFw1WQkdG5BUBww/cUzURkPn3v4xkLxkei6psNQf0tyaEocNPw2rzDynOzPSJ0Xc3HqTY4y5J+1AxNc5DNOU17qlBlZD/dPyTDf+H9K+sZiyyVaJVuWszHyfkPCnzSaSYvwgidSvA2Pc5nvqMtLxKL2GPfafZkqkOw+QQrbTEwdRQIwNtIMq6CTyqDV2mX7uBFTWvq3L5iwsq0IR7Lm1wokOd4ysajXA==;25:2Oiq6ZUiigJXX5bsZZ1WFI4THD9utQhR4SXu7o88PVY6MigDvCPWKAT1JftVoQm1CUeRTb1RXwuo2/ccy+MysJxMjZT1iUN4lcciYg44JPURNmZed+os3a5YNVaaPnrFhn6x3AqPVn6V2VHl7CLmPxXcCcEu71StXaDuWInBC0/LbZv/L/5Mp+nj7zXOPLooZEV/YFsJ3CsuOatUKMbGdgmlEnN9EIulJYg6w/IcrvEF2oCMEDozbCiYLzyVUZFuB+k/Jd0yn8tgrIKFO+b9MBOoN3PhrN7sVkqIhopvYMViEOzwhHXuWKE+o5WN4gPG2IdwXiIHmZaXojA4aweZ1vP3LCGFXnbhF+Z9uEfRPwqLFr2YZrwWWpu422Wh0cmHs3GTRokbB+YQUs2ElyVm0Q93MEjAzxGIjYwMllZeiEPx4MJhr4orPVknlfkyQ6fIq1eBJKc1tfxZXY5DFtzxAQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB1726;31:QWBFniIP4LzVZSU7yTKuec31Shby+STMobLV0HiWU4Ap13xCNydd9ixJ69EExqItnKz/dDBXB3HH1cSTYoKxf8EjOhYLPUNT5BIJMZQRqxtOpPuOyhBu03AUhtFNP12iFa/2ZMndcWJOLbOGz6YqpIo6Xx1Vuk61xyhnkmbJ/0dy7kWDDhlqNb2s9qcPDj3dS35ZZVt52VQJXNtjEcY5eUN68YOjLuKEgMYL+4Vr2g3fg89GyqmHsbHbxV1m+Q69n2U5rrko/r0yIlXRxD/01ol/qxvCev/BWTPn8P0EhQ4=;20:+08BOgePvvZ0B2dbAgWTGffm/sCLAIskGqrsPBaA5VGj1ZiCONq9U1t/fZadFJMazCOFqUewkJAbil1P5L5Qb7g7aS6ump24yz8tApu32Eu5Wc7gf/LK7aoLk7rXCm3H+Tpt/IX1IOhKWpYobyKAVcrEwJ08uEzBibjGSV8WH7TYjfQ5gszYqLnxmxlst8zrO28HtfnzoPeV2NhAq6wqhbRbPlIhwIrpGCe3tXBO3kSxDEK6XVZ7b2vYEkCa+Vo5Nu/K517qeLm7FGvFN4nWvycnM4VLa612FDNAOAe9O7s5BlvgjjZcjFgIV2c2vThPUkjAoifIUkKD3I5Ujk4uHp4rI8BQtzF24vLuQlsgyBdObeWSEqItA4IVeA1wyQEKAzXDLcWBR1EsFZSecbXqGXw76opjUj1eoYNNjNptZeZfH80RSXbDXy9JjytzfrCgTbHTPfOigbjaYA7XTRDlcg4IDlA4YJ3nJLpw1qfVhvUpScQZIlzNuG1f4UV6PCVv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(6072148);SRVR:VI1PR07MB1726;BCL:0;PCL:0;RULEID:;SRVR:VI1PR07MB1726; X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB1726;4:B6DlFF6G9UZKOk5qGxLZOR2U4SjT2Y8QH9cypLsJIgmSiTu0/slr/njUI2nGgy7BCTF1tFVi5AhWbyuBj7f8NMP31bxdzpWfcHZ2vrIG4BpL8ZirxnVGtMx6xo8S3HiVfaXOohS4iy+f9K+vtsCeNktc1KAQpuhRLsCSoczZBRRKDDhjg3lMF6iC1IxgESd3uUDfym/K72h4LTRYZRnXxZ06hEV4jEpeS0BcALOhgKKBXzsy7BSpU9WBY/mzlnmBMjGs6J7z1DbU/sj7268b1DQ5P/IrR04qMyUYISdiVhWkD3e54/oYljAzUmeokqGM4YMsIrFNWs3/Lsop/yaUACJYoeMDBZt+NVmadEgGR0NbWS1OgE6gPQl0TQS5ZAXIK4mRmfY6Zo9dO3w74lV3K4FywQfBTdvUI2jU8eSRnrCSGdOGKugq30zO4AnFf+AI9piRSDXWa5GRB7cWrTkH5l+rxZOPTNZ97co7XoSpP/ha6KxzubCFdrmF+ysEfqmq0wFvaUv4xQ0hbV7j68A0PxC8MGMQoUIw83d+vz+ndc4hADOK5t82Q6u7kzzmmMtjdroiUrnGxG3VFJ3OiFUiDJJcr2u26Gw/34UYGCzWuJFkl70e1QqVq+qDJARFDzCxNDn6OH/Tanab8uwbsojckwb3dL+47zc750UG6w6w+RF4onh6/LCHsxTxLGveqEvISvEwLdydjXu7kCGVUU5Cigap1P4r9mKnQMg+M+2naCfNlR5hBYnCZ4v3xrsIidv3E6gnX9xutcRw/lSRQ8N70w== X-Forefront-PRVS: 0270ED2845 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39400400002)(39410400002)(39850400002)(39450400003)(39840400002)(39860400002)(377454003)(24454002)(377424004)(4326008)(305945005)(25786009)(7736002)(38730400002)(50986999)(23746002)(6246003)(53546009)(6116002)(3846002)(81166006)(229853002)(8676002)(54356999)(76176999)(6666003)(2950100002)(2906002)(189998001)(4001350100001)(33646002)(31696002)(65826007)(50466002)(31686004)(42186005)(6306002)(36756003)(5660300001)(47776003)(53936002)(66066001)(86362001)(83506001)(6486002)(90366009)(64126003)(65956001)(78286005);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR07MB1726;H:[142.133.50.178];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR07MB1726;23:aFqGSC6bi/GcStffcVcW2hdjVKYFmciyI8jad?= =?Windows-1252?Q?x45RSuqjirFQwo8tSvBxO++qvSzQQITlNfYxC038V6+pCs5RFT/CZ2by?= =?Windows-1252?Q?0ojmkzHBF22vNLGnI++WeAt2n+qj+dccVeW/4OMODE3cwbHFcoBZnigB?= =?Windows-1252?Q?MupVivzXYwYQgY/d+71+GTnwim5GSbyl9uBijHRReBFTXoQdhVXU4/gK?= =?Windows-1252?Q?UmFJmcR3P7BPB76lIsbVXqINIw2ORAAgJ2Eq4Ih6JQf1nRdjYQDTcHVu?= =?Windows-1252?Q?1pCu165Hi+0CLxgg7itdcftLT85SHdMnqsaSgVJR8t8W9ld2MG/QCXGh?= =?Windows-1252?Q?Pa/rPVsWhAqzfQ8XTKq6M6wpl0QtEAch4Jhq0SkRjSBOucjUh0k4DI0M?= =?Windows-1252?Q?1qfrCx/g1KsMcm5Eyan6GwJvpuJNs1mVYcGEjjn8XIiUbgrCzJzRNppV?= =?Windows-1252?Q?gV9q7LDePAW6R4UmVKCZgow/FqmdMcxbd09qvsscvxUDGk7pKX908eQ2?= =?Windows-1252?Q?9bHILV94rRRqWS5U5tqp64yViU4RZ5VT/IyyPnivEaCQAJ5BrnUGDAI2?= =?Windows-1252?Q?sHi16RXEzW6FnKsskEHcz+roGOA5SF11TNM6h0v3QDQfkNnkLh/2jv4A?= =?Windows-1252?Q?Cvsu7Ys4kYKjPZ1PfuWrxk8mwORnZnsJ8WF3unWyUUqntPaVTgyHUtxj?= =?Windows-1252?Q?/cnCYWbUVpoNoPEylCnhotFvULALQqxlrxjBBybNvBVNZPD+pYrcmOcK?= =?Windows-1252?Q?hywZ3LeVXJJxuWcO4dqwqWSuei9E5b5ocQ080/lfi/OVJ2fkqQ+UCmp2?= =?Windows-1252?Q?qvIbHVhxpaNcg0M4CDeqMNY//NSuySCtLcFEcYaZw37+456s4j91ci+V?= =?Windows-1252?Q?3nnvXphPad05zjE5C9Fv30Yly/m8tRwDPgF/EZ00+ppbXrzQtES+T1y/?= =?Windows-1252?Q?jXGYTEo3lVG3byItQgd9MK3FOUyu62vKWwEXJ6MhFWFxGkzLKhaI25Yn?= =?Windows-1252?Q?Xxu5SwSb3GIET7LfpVdQkIJ+2Sh1e+nZRs1V2PdguAMDeLxe9d43GRWv?= =?Windows-1252?Q?GHier/JcsfX6l54RfNtBSwxid6alxcTDHRjhi9/fsM43mnalgIAW+2J8?= =?Windows-1252?Q?zhKlM40NaS8AzPkN5gZGQQWVndyY8U8TevUKBs0/VIhvuWHM0kAy5ILE?= =?Windows-1252?Q?bOFSweR6FlamITDkymBbzNu+q3Zjsqjq3U13c6v6nu3ZLLWp+26L9ynF?= =?Windows-1252?Q?2gi2Tb+/R3968tt3i9Iq7eLaGVgTG2WKMBHv6jOHbF+QS4nZBW76GC0N?= =?Windows-1252?Q?OArgX0d1adezMyBKHxhiEqqmzrxTcJP/fmvcLlFqr28V57Edljpq8wLx?= =?Windows-1252?Q?HFzm065B1sBOCZeBdNQlGAEsWhkOwaF0Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB1726;6:8OYEeBS/YcLRGorhtUgP+XUUHinX6ihjBGlCyH7Zx/qwCG6k13AnmJddYmLk1UVwdCnzLBoaZeAjDqyhHpnKBBERO9zloeUyHXtYSUnicsf+nA6/H5VX1VgEFak2dAzs58GCPAd/EUMI9qbalDU2irD2Uj3tO/PdcKGQRGmZKmBSZMAl6v/5+C44aGOEOFF1ZP2U1zggepxOShqRmhClNzJlIU532OUbciDgA9s1PJdiUv0KVikAJlDgqUDgYcLT1ZKPJ3/Ndy1NHNhYZbw+YojLOXy6dF58e9JtGLLCsx/EEzt7v5IEF8sfKgzKmNjveY3mCTVYylmla0pChoCMVBkGCUFcEn6VRxQt7WiVS5IAwOGqxiWtn4eto3DQ1DFlQmZMfbc7E+lxBlyhy3WQ/fDVHfIYK//KzS14K0hlbBHeJ7TbKMdkyT4RWhCQgqNQRafmBePn0VWi6OzjaT3LUw==;5:NJPq4wKJxcg98Fk04+qpUZT6rK8ZJP6gICorSGDzC0LF8RfpL0CSKAbQWqbGHZGEjusxp7TMsvGz2vxCOJvtcyPa+tHVfmHHANjDCPDiJJzNOsNdTEnVePsEewZFXCKb6WV3squeGXDbFLPLmBC6hQ==;24:1Ap5LwOlGoKFw+9jG3WqfJLTP5Somp/gLY6pV/9iJAUIODRZ0TpoCDjS3IzUneufNHWG5VywDpXSfDWiAOV25lh8YAi2of/ZaTso+1/kdSo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB1726;7:KDUyaicCRmWRyCP+GsqRvia4aXWXbMO3O/4agbqZZTqApgzZQrbtQFFYVyK05nkXCyA7nB2WvL1lKL9RzAtnW6pJj2YHIg10Wx4XENXFGag/MErj2knp3ADQRnfQvn2GlnY22V7VVY9Wm2DNuf+FezvEiKCp7mJ0tM2gjzjvolNvOBx2Sq/ecOXn2I2GbOGRWADalQf1lTidKqe/pnUlQvLcOROuOlp1mdL+DKFGVeb/F2YCjJ5oRLaWYWZJVc1y7be2LcKjnxUc+CtJlb+xyB4Z0BeaVWywgKqfRn+V7ERccA4ccwJqU8Jd9zFo2OQrmp2wxHeY26EEc6n/zgwfgg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2017 14:33:55.4928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1726 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00168.txt.bz2 On 17-04-07 06:48 AM, Pedro Alves wrote: > On 04/07/2017 10:25 AM, Philipp Rudo wrote: > >> In this context I ask myself what the error message is supposed to >> say (unfortunately you are the first one in GDB actually using it, all >> others only use an empty string). Is it what's expected ... >> > > That's because the static assertion failure text includes both a > file:line indicating where's the failure, and modern gcc/clang > show you the line that failed, so it's not that big of a deal to > not include a message: > > src/gdb/thread.c:1589:1: error: static assertion failed: > static_assert (1 == 0, ""); > ^ > $ > > (and in C++17, static_assert got an overload with no second > parameter, even.) > >> >> static_assert (pid == ptid_t (1, 0, 0), "pid operator== returned false") >> >> >> I tend more to what is expected. > > Definitely it should say what is expected, just like regular > testsuite tests. Or say nothing when the expression is pretty clear > already, which works for me too. :-) Heh, why did you not say that earlier, it would have saved me some time ;) @Philipp: To come back to the verb tense thing. Now that I think of it, when I read the lines, I mentally insert a "that" in there. So static_assert (!pid.matches (lwp), "pid doesn't match lwp"); becomes mentally assert that pid doesn't match lwp I think it comes from using jUnit's assertThat: https://github.com/junit-team/junit4/wiki/matchers-and-assertthat Simon