From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55097 invoked by alias); 26 Nov 2018 21:07:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55082 invoked by uid 89); 26 Nov 2018 21:07:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=holder, Hx-languages-length:1416 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 21:07:51 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wAQL7iD9014505 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Nov 2018 16:07:48 -0500 Received: by simark.ca (Postfix, from userid 112) id 343C71E992; Mon, 26 Nov 2018 16:07:44 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id BD6641E473; Mon, 26 Nov 2018 16:07:35 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Nov 2018 21:07:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: gdb-patches@sourceware.org, vapier@gentoo.org Subject: Re: [PATCH 1/2] sim/opcodes: Allow use of out of tree cgen source directory In-Reply-To: <0745ff244d76a8cd8ec7e7b9a53840f3773a139d.1541525137.git.andrew.burgess@embecosm.com> References: <0745ff244d76a8cd8ec7e7b9a53840f3773a139d.1541525137.git.andrew.burgess@embecosm.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00448.txt.bz2 On 2018-11-06 12:35, Andrew Burgess wrote: > diff --git a/opcodes/configure.ac b/opcodes/configure.ac > index 4c3698356b..9e48fedf9a 100644 > --- a/opcodes/configure.ac > +++ b/opcodes/configure.ac > @@ -109,11 +109,21 @@ AC_ARG_ENABLE(cgen-maint, > yes) cgen_maint=yes ;; > no) cgen_maint=no ;; > *) > - # argument is cgen install directory (not implemented yet). > - # Having a `share' directory might be more appropriate for the .scm, > - # .cpu, etc. files. > + # Argument is a directory where cgen can be found. In some > + # future world cgen could be installable, but right now this > + # is not the case. Instead we assume the directory is a path > + # to the cgen source tree. > cgen_maint=yes > - cgendir=${cgen_maint}/lib/cgen > + if test -r ${enableval}/iformat.scm; then > + # This looks like a cgen source tree. > + cgendir=${enableval} > + else > + # This code would handle a cgen install. For now we assume > + # 'lib', but this is really just a place holder. Maybe > + # having a `share' directory might be more appropriate for > + # the .scm, .cpu, etc. files. > + cgendir=${enableval}/lib/cgen > + fi > ;; > esac])dnl > AM_CONDITIONAL(CGEN_MAINT, test x${cgen_maint} = xyes) Just wondering, does the "else" part have any real-world use? Before today, was there any reason to pass a path to --enable-cgen-maint ? Simon