From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id l2SLIo6Lh2ALeAAAWB0awg (envelope-from ) for ; Mon, 26 Apr 2021 23:57:02 -0400 Received: by simark.ca (Postfix, from userid 112) id 7EFA51F11C; Mon, 26 Apr 2021 23:57:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D4D8E1E54D for ; Mon, 26 Apr 2021 23:57:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FC5E3857C71; Tue, 27 Apr 2021 03:57:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FC5E3857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619495821; bh=+MvgFXnS5qw+9coEi6uNxvMGZC54O94By9L+EpiZ0zA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HS0FSPf95cp/2Pg4vYta6Bw/lgkBncQSKJ0Efcyk/ime3/RBkk3uKSa76F9havuBK 4iACTgIvjgi8FXaPcvlTaC+hKBbfSGgvIXu8/ktLnQ55yebNy7XJDtfhZhIWb+FFKv GHhuNR6Qtcpe2yKn5dfgwH6d8Pq1yftzszTf8des= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 79C48385802A for ; Tue, 27 Apr 2021 03:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79C48385802A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13R3upmp021286 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Apr 2021 23:56:56 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13R3upmp021286 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9F7011E54D; Mon, 26 Apr 2021 23:56:51 -0400 (EDT) Subject: Re: [PATCH 09/43] Move push_dwarf_reg_entry_value to expr.c To: Zoran Zaric , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-10-Zoran.Zaric@amd.com> Message-ID: Date: Mon, 26 Apr 2021 23:56:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301144620.103016-10-Zoran.Zaric@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Apr 2021 03:56:51 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c > index 872de16cd70..0b7f3c90728 100644 > --- a/gdb/dwarf2/expr.c > +++ b/gdb/dwarf2/expr.c > @@ -268,6 +268,57 @@ dwarf_expr_context::read_mem (gdb_byte *buf, CORE_ADDR addr, > read_memory (addr, buf, length); > } > > +/* See expr.h. */ > + > +void > +dwarf_expr_context::push_dwarf_reg_entry_value > + (enum call_site_parameter_kind kind, > + union call_site_parameter_u kind_u, > + int deref_size) When the parameter list doesn't fit in the right of the name, we typically to: void dwarf_expr_context::push_dwarf_reg_entry_value (enum call_site_parameter_kind kind, union call_site_parameter_u kind_u, int deref_size)o If we need to wrap, we might as well start completely on the left, that leaves more space :). Simon