From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zvGAHoab4mLt+RsAWB0awg (envelope-from ) for ; Thu, 28 Jul 2022 10:21:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 6DD341E9ED; Thu, 28 Jul 2022 10:21:58 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=tYa1BXqP; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB53D1E9E9 for ; Thu, 28 Jul 2022 10:21:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62130385AE46 for ; Thu, 28 Jul 2022 14:21:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62130385AE46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659018117; bh=jTubfggggpFZLK3+9aAcTHV61PdPnAWTEHwXdYKP+iQ=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tYa1BXqPp7AQ31xvZoGKPOQNl8LzVbf5cDFVqHBkdzns5PsUaIHKg7eXukK9EuzNw E8NNJCXbsedfk5BXo8WwFbLqVqJA95nqXOZdYovNqprtYpao+qBv8k8eCfMupdM7Wk F/Rwa4xvl2bd4qbPMugiHvPjCtKZnHOs98FeC89w= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 2C5BC385800B for ; Thu, 28 Jul 2022 14:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C5BC385800B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67F053412F; Thu, 28 Jul 2022 14:21:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3950613A7E; Thu, 28 Jul 2022 14:21:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ABKeDHCb4mJFXQAAMHmgww (envelope-from ); Thu, 28 Jul 2022 14:21:36 +0000 Content-Type: multipart/mixed; boundary="------------EThz0M3vFdnjD0lctV0E5c08" Message-ID: Date: Thu, 28 Jul 2022 16:21:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.ada/literals.exp with aarch64 Content-Language: en-US To: Joel Brobecker References: <20220727103447.GA9310@delia> <8f343881-a96d-9eef-8cbc-9afc69f97d7d@suse.de> In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------EThz0M3vFdnjD0lctV0E5c08 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/28/22 15:10, Joel Brobecker wrote: >>> Thanks for the patch. >>> >>> My question is whether it actually makes sense that -1 be >>> a valid output for the print command above. I tried the addition >>> of ... >>> >>> | /* Note: Interprets ULLONG_MAX as -1. */ >>> | yylval.typed_val.type = type_long_long (par_state); >>> >>> ... to a patch of yours: >>> >>> | commit ac3afe36d73c84096685fece885d70b28bc9629f >>> | Author: Tom de Vries >>> | Date: Sat Jun 4 13:17:33 2022 +0200 >>> | Subject: [gdb/ada] Fix literal truncation >>> | >>> | Make sure we error out on overflow instead of truncating in all cases. >>> | >>> | Tested on x86_64-linux, with a build with --enable-targets=all. >>> >>> Do you remember why we do this? Intuitively, you'd expect that GDB >>> would behave the same regardless of whether it selects type "long" >>> or "long long" for its processing, as long as both types are 64-bit. >>> >> >> I have no idea. AFAICT it's been in gdb since the "Add base ada language >> files" commit from 2002 that we avoid "unsigned long long". >> >> I've taken care to preserve the behaviour in the commit you refer to (and >> this patch), since I don't have the knowledge to decide that things should >> be different. >> >>> With the above, we can take this patch as an intermediate remedy, >>> but I think we might need to dig deeper into why we use a signed >>> type in the case of long long but not long, particularly when both >>> types are the same size. >>> >>> WDYT? >>> >> >> I'd be happy to write a patch to change the behaviour of gdb. But somebody >> knowledgeable in Ada needs to specify what that needs to be. > > We're really outside of the Ada language. Would you mind checking > what the C language does? I think it would make sense to do the same, > here. E.g., on x86_64-linux, I get: > > (gdb) p 0xffffffffffffffff > $1 = 18446744073709551615 > Ack, that's what the C language does. This patch changes gdb to print 18446744073709551615 for ada as well. So, pick your favorite patch ;) Thanks, - Tom --------------EThz0M3vFdnjD0lctV0E5c08 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Fix-gdb.ada-literals.exp-with-aarch64.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Fix-gdb.ada-literals.exp-with-aarch64.pat"; filename*1="ch" Content-Transfer-Encoding: base64 W2dkYi90ZXN0c3VpdGVdIEZpeCBnZGIuYWRhL2xpdGVyYWxzLmV4cCB3aXRoIGFhcmNoNjQK Ck9uIGFhcmNoNjQtbGludXgsIEkgcnVuIGludG86Ci4uLgooZ2RiKSBwcmludCAxNiNmZmZm ZmZmZmZmZmZmZmZmI15NCiQ3ID0gMTg0NDY3NDQwNzM3MDk1NTE2MTVeTQooZ2RiKSBGQUlM OiBnZGIuYWRhL2xpdGVyYWxzLmV4cDogcHJpbnQgMTYjZmZmZmZmZmZmZmZmZmZmZiMKLi4u CndoaWxlIG9uIHg4Nl82NC1saW51eCBpbnN0ZWFkLCBJIGdldDoKLi4uCihnZGIpIHByaW50 IDE2I2ZmZmZmZmZmZmZmZmZmZmYjXk0KJDcgPSAtMV5NCihnZGIpIFBBU1M6IGdkYi5hZGEv bGl0ZXJhbHMuZXhwOiBwcmludCAxNiNmZmZmZmZmZmZmZmZmZmZmIwouLi4KCldlIGNhbiBl YXNpbHkgcmVwcm9kdWNlIHRoaXMgb24geDg2XzY0LWxpbnV4IHVzaW5nOgouLi4KJCBnZGIg LXEgLWJhdGNoIC1leCAic2V0IGxhbmcgYWRhIiAtZXggInNldCBhcmNoIGkzODYiIFwKICAt ZXggInByaW50IDE2I2ZmZmZmZmZmZmZmZmZmZmYjIgokMSA9IC0xCiQgZ2RiIC1xIC1iYXRj aCAtZXggInNldCBsYW5nIGFkYSIgLWV4ICJzZXQgYXJjaCBhYXJjaDY0IiBcCiAgLWV4ICJw cmludCAxNiNmZmZmZmZmZmZmZmZmZmZmIyIKJDEgPSAxODQ0Njc0NDA3MzcwOTU1MTYxNQou Li4KCldpdGggaTM4Niwgd2UgaGF2ZToKLi4uCihnZGIpIHAgaW50X2JpdHMKJDMgPSAzMgoo Z2RiKSBwIGxvbmdfYml0cwokNCA9IDMyCihnZGIpIHAgbG9uZ19sb25nX2JpdHMKJDUgPSA2 NAouLi4KYW5kIHNvIGluIHByb2Nlc3NJbnQgd2UgaGl0IHRoZSBmaXRzLWluLXVuc2lnbmVk LWxvbmctbG9uZyBjYXNlIHdoZXJlIHdlIHVzZQphcyB0eXBlIGxvbmcgbG9uZzoKLi4uCiAg ICAgIC8qIE5vdGU6IEludGVycHJldHMgVUxMT05HX01BWCBhcyAtMS4gICovCiAgICAgIHl5 bHZhbC50eXBlZF92YWwudHlwZSA9IHR5cGVfbG9uZ19sb25nIChwYXJfc3RhdGUpOwouLi4K CldpdGggYWFyY2g2NCwgd2UgaGF2ZSBpbnN0ZWFkOgouLi4KKGdkYikgcCBpbnRfYml0cwok MSA9IDMyCihnZGIpIHAgbG9uZ19iaXRzCiQyID0gNjQKKGdkYikgcCBsb25nX2xvbmdfYml0 cwokMyA9IDY0Ci4uLgphbmQgc28gaW4gcHJvY2Vzc0ludCB3ZSBoaXQgdGhlIGZpdHMtaW4t dW5zaWduZWQtbG9uZyBjYXNlIHdoZXJlIHdlIHVzZQphcyB0eXBlIHVuc2lnbmVkIGxvbmc6 Ci4uLgogICAgICB5eWx2YWwudHlwZWRfdmFsLnR5cGUKICAgICAgICA9IGJ1aWx0aW5fdHlw ZSAocGFyX3N0YXRlLT5nZGJhcmNoICgpKS0+YnVpbHRpbl91bnNpZ25lZF9sb25nOwouLi4K Ckl0J3Mgbm90IGNsZWFyIHdoeSBmb3IgYWRhIHdlJ3JlIHVzaW5nIGxvbmcgbG9uZyBmb3Ig dGhlCmZpdHMtaW4tdW5zaWduZWQtbG9uZy1sb25nIGNhc2UuCgpGaXggdGhpcyBieSB1c2lu ZyB1bnNpZ25lZCBsb25nIGxvbmcgZm9yIHRoZSBmaXRzLWluLXVuc2lnbmVkLWxvbmctbG9u ZyBjYXNlLAptZWFuaW5nIHRoZSBuZXcgcmVmZXJlbmNlIG91dHB1dCBpcyAxODQ0Njc0NDA3 MzcwOTU1MTYxNSBpbnN0ZWFkIG9mIC0xLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eC4KCkJ1 ZzogaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9Mjk0 MTYKCi0tLQogZ2RiL2FkYS1sZXgubCAgICAgICAgICAgICAgICAgICAgICB8IDQgKystLQog Z2RiL3Rlc3RzdWl0ZS9nZGIuYWRhL2xpdGVyYWxzLmV4cCB8IDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dk Yi9hZGEtbGV4LmwgYi9nZGIvYWRhLWxleC5sCmluZGV4IDAwMmViODExZTQxLi5lZDg4ZDUw MmU5ZiAxMDA2NDQKLS0tIGEvZ2RiL2FkYS1sZXgubAorKysgYi9nZGIvYWRhLWxleC5sCkBA IC00OTgsOCArNDk4LDggQEAgcHJvY2Vzc0ludCAoc3RydWN0IHBhcnNlcl9zdGF0ZSAqcGFy X3N0YXRlLCBjb25zdCBjaGFyICpiYXNlMCwKICAgICB5eWx2YWwudHlwZWRfdmFsLnR5cGUg PSB0eXBlX2xvbmdfbG9uZyAocGFyX3N0YXRlKTsKICAgZWxzZSBpZiAoZml0c19pbl90eXBl ICgxLCB2YWx1ZSwgbG9uZ19sb25nX2JpdHMsIGZhbHNlKSkKICAgICB7Ci0gICAgICAvKiBO b3RlOiBJbnRlcnByZXRzIFVMTE9OR19NQVggYXMgLTEuICAqLwotICAgICAgeXlsdmFsLnR5 cGVkX3ZhbC50eXBlID0gdHlwZV9sb25nX2xvbmcgKHBhcl9zdGF0ZSk7CisgICAgICB5eWx2 YWwudHlwZWRfdmFsLnR5cGUKKwk9IGJ1aWx0aW5fdHlwZSAocGFyX3N0YXRlLT5nZGJhcmNo ICgpKS0+YnVpbHRpbl91bnNpZ25lZF9sb25nX2xvbmc7CiAgICAgICAvKiBTZWUgdW5zaWdu ZWQgbG9uZyBjYXNlIGFib3ZlLiAgKi8KICAgICAgIGlmICh2YWx1ZSAmIExPTkdFU1RfU0lH TikKIAl5eWx2YWwudHlwZWRfdmFsLnZhbCA9CmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRl L2dkYi5hZGEvbGl0ZXJhbHMuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuYWRhL2xpdGVyYWxz LmV4cAppbmRleCBhNmFjODliNTQwZi4uNmJhZGM4NTcyOTIgMTAwNjQ0Ci0tLSBhL2dkYi90 ZXN0c3VpdGUvZ2RiLmFkYS9saXRlcmFscy5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIu YWRhL2xpdGVyYWxzLmV4cApAQCAtMzYsNCArMzYsNCBAQCBnZGJfdGVzdCAicHJpbnQgMTYj ZiNlMSIgIiA9IDI0MCIKIGdkYl90ZXN0ICJwcmludCAxNiMxI2UxMCIgIiA9IDEwOTk1MTE2 Mjc3NzYiCiAKIGdkYl90ZXN0ICJwcmludC94IDE2IzdmZmZmZmZmZmZmZmZmZmYjIiAiID0g MHg3ZmZmZmZmZmZmZmZmZmZmIgotZ2RiX3Rlc3QgInByaW50IDE2I2ZmZmZmZmZmZmZmZmZm ZmYjIiAiID0gLTEiCitnZGJfdGVzdCAicHJpbnQgMTYjZmZmZmZmZmZmZmZmZmZmZiMiICIg PSAxODQ0Njc0NDA3MzcwOTU1MTYxNSIK --------------EThz0M3vFdnjD0lctV0E5c08--