From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@efficios.com>
Received: from mail.efficios.com (mail.efficios.com [167.114.26.124])
 by sourceware.org (Postfix) with ESMTPS id EFE11385E82C
 for <gdb-patches@sourceware.org>; Mon, 16 Mar 2020 18:18:01 +0000 (GMT)
Received: from localhost (localhost [127.0.0.1])
 by mail.efficios.com (Postfix) with ESMTP id 5F92726D0D4;
 Mon, 16 Mar 2020 14:18:01 -0400 (EDT)
Received: from mail.efficios.com ([127.0.0.1])
 by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id 1JO2KJr7Cf8G; Mon, 16 Mar 2020 14:18:01 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
 by mail.efficios.com (Postfix) with ESMTP id 2FF2626D0D3;
 Mon, 16 Mar 2020 14:18:01 -0400 (EDT)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 2FF2626D0D3
X-Virus-Scanned: amavisd-new at efficios.com
Received: from mail.efficios.com ([127.0.0.1])
 by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id IZzC5t9hSf4v; Mon, 16 Mar 2020 14:18:01 -0400 (EDT)
Received: from [10.0.0.11] (unknown [192.222.164.54])
 by mail.efficios.com (Postfix) with ESMTPSA id 14F6326D1EB;
 Mon, 16 Mar 2020 14:18:01 -0400 (EDT)
Subject: Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries
To: Christian Biesinger <cbiesinger@google.com>,
 Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches <gdb-patches@sourceware.org>,
 Jon Turney <jon.turney@dronecode.org.uk>
References: <20200316170845.184386-1-simon.marchi@polymtl.ca>
 <20200316170845.184386-7-simon.marchi@polymtl.ca>
 <CAPTJ0XEg+eWuQ7xSw4KzhvMCj8O0zMtrf-x2L1VP=WB8m=Wfew@mail.gmail.com>
From: Simon Marchi <simon.marchi@efficios.com>
Message-ID: <c8d94651-0085-f7b1-3394-4c286e450cad@efficios.com>
Date: Mon, 16 Mar 2020 14:18:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <CAPTJ0XEg+eWuQ7xSw4KzhvMCj8O0zMtrf-x2L1VP=WB8m=Wfew@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED, DKIM_VALID,
 DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE,
 SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2020 18:18:02 -0000

On 2020-03-16 2:16 p.m., Christian Biesinger wrote:
>> @@ -898,6 +900,105 @@ static const struct internalvar_funcs tlb_funcs =
>>    NULL
>>  };
>>
>> +/* Layout of an element of a PE's Import Directory Table.  Based on:
>> +
>> +     https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#import-directory-table
>> + */
>> +
>> +struct pe_import_directory_entry
>> +{
>> +  uint32_t import_lookup_table_rva;
>> +  uint32_t timestamp;
>> +  uint32_t forwarder_chain;
>> +  uint32_t name_rva;
>> +  uint32_t import_address_table_rva;
>> +};
>> +
>> +gdb_static_assert (sizeof (pe_import_directory_entry) == 20);
>> +
>> +/* Return true if the Portable Executable behind ABFD uses the Cygwin dll
>> +   (cygwin1.dll). */
>> +/* See windows-tdep.h.  */
> 
> Remove the first of these two comments?

Indeed, thanks.

Simon