From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nCpPBKzZRmTUSTUAWB0awg (envelope-from ) for ; Mon, 24 Apr 2023 15:34:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 009231E221; Mon, 24 Apr 2023 15:34:03 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=P3HAqTEb; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B0AEC1E0D3 for ; Mon, 24 Apr 2023 15:34:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 404663858414 for ; Mon, 24 Apr 2023 19:34:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 404663858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682364842; bh=2U8ms4/ndcdKrADJOAgM81lJQ2r0Fv43Mq9v2V9Tgz8=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=P3HAqTEbbdviJ2kacXzRQFNCg5vD7sqRYP2blPb7+otiP3d3Unv+IWwYTCEI9AdHx zP4IIlG7QjUvbjo/IH6SD+t/gIviSNwlbb+Z9wmTaf0DLojBxV9NfH8sUTxq5OzAov 939FQjjVGw/rb3hpp/UJ/bW1sr9jx9YaO0ufWwK0= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0E0793858D1E for ; Mon, 24 Apr 2023 19:33:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E0793858D1E Received: from [10.0.0.170] (unknown [167.248.160.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A8F9D1E0D3; Mon, 24 Apr 2023 15:33:42 -0400 (EDT) Message-ID: Date: Mon, 24 Apr 2023 15:33:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Remove some "goto"s from parse.c Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20230424190403.1550146-1-tromey@adacore.com> In-Reply-To: <20230424190403.1550146-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 4/24/23 15:04, Tom Tromey via Gdb-patches wrote: > parser_state::push_dollar has some unnecessary "goto"s. Replacing > them cleans up the code. Regression tested on x86-64 Fedora 36. Thanks, LGTM. Approved-By: Simon Marchi Simon