From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tonkL4cLa2kLMAcAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 23:09:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768622983; bh=Iu3l48BrppYp2uicA4tPXOsqpoVgBupU5Nz60MF1sKc=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=f8p7KadviBfyNjQxuoW4zKq5wEHzXTwljwmK0yG3E8aqFhn8WNzU8siOkTneuUztW 7FRxOS8DW/quX0joIaSpc/KcZ07C8Q5fFUblBDgsBhO7gndjaXgdBKgooMrzZverb1 LqhuyfNfvz7drhvYa0L+pXcgRzZZY/GsaykTdj2Y= Received: by simark.ca (Postfix, from userid 112) id B64611E0DD; Fri, 16 Jan 2026 23:09:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=iuriARnW; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4AF201E08D for ; Fri, 16 Jan 2026 23:09:43 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CCC224BA2E3D for ; Sat, 17 Jan 2026 04:09:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCC224BA2E3D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=iuriARnW Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 617EE4BA2E22 for ; Sat, 17 Jan 2026 04:09:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 617EE4BA2E22 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 617EE4BA2E22 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768622958; cv=none; b=Sy9Ron96aCPjRkt0MNFh6BGUPclthif1rAMQqnO5x1icexaPHcIOkrb8GzCbGL05EM0AJSyrdaX0xpCeBhnzrQz8WCqpEBR78bSxLf6Itd1Dg3arqTm04nnzNtz/6iYjh2fZGXC7JLSSTutUm3/rFMIT96n7HbCINXCoiAvTJM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768622958; c=relaxed/simple; bh=Iu3l48BrppYp2uicA4tPXOsqpoVgBupU5Nz60MF1sKc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bwEEWQbwOftBqOowAJ8MMzXOqrUWDO5sGxMqUpJNLXD3KYavAZDBacJlsd/VXhVSUxCrRMmSAE+WYjSSvDvR5r2G6iMgvs6Rd8Y0ayA6dpIlcN6TZsaQ3FRdZu6at9li6BE4zX997wN9DNuT5LabBrsIUKaxDxNBsVOfKOfRz1g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 617EE4BA2E22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768622957; bh=Iu3l48BrppYp2uicA4tPXOsqpoVgBupU5Nz60MF1sKc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=iuriARnWmzrBvl/2xRxud4RCV1Y0agY3imK3F35Zn6DSXYt7HrAGiu7EM60OEB8bP xnuPrz3uY+Zjl6DdiNYQ0/qM59Qji/PZNpnn4B6aAt8fyIm0I2qe/Sl0dZUzUtnyzJ VjSBWippqi3PiS986NIoOxwRx/1r3aHR3Q7veJdk= Received: by simark.ca (Postfix) id B05D41E08D; Fri, 16 Jan 2026 23:09:17 -0500 (EST) Message-ID: Date: Fri, 16 Jan 2026 23:09:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] Use symfile_bfd in more places To: Tom Tromey , gdb-patches@sourceware.org References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> <20260116-coffread-cleanups-v1-6-4d46090fad69@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260116-coffread-cleanups-v1-6-4d46090fad69@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-16 14:11, Tom Tromey wrote: > Since coffread.c is setting symfile_bfd, it might as well use it > everywhere. This changes all other BFD references in coffread.c to > use the global. I think you should just remove symfile_bfd too. - add a bfd parameter to read_one_sym - coff_symtab_read can pass objfile->obfd to read_one_sym - init_stringtab refers to symfile_bfd, but it already receives the same bfd by parameter, so it can just use the parameter Simon